Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom_js site param for enabling custom js #182

Merged
merged 4 commits into from May 23, 2019

Conversation

Projects
None yet
2 participants
@mrozlukasz
Copy link
Contributor

commented May 20, 2019

I've hit that when adding Cookie Consent on my web page. https://github.com/insites/cookieconsent

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

Description

Allows to add custom javascript source files in html head page. I need this for features like Cookie Consent.

Issues Resolved

Haven't seen any related

Checklist

Put an x into the box(es) that apply:

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively
  • Reference issue with #<ISSUE_NO> if applicable

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already
Add custom_js site param for enabling custom js
I've hit that when adding Cookie Consent on my web page. https://github.com/insites/cookieconsent
Show resolved Hide resolved layouts/_default/baseof.html Outdated
@luizdepra

This comment has been minimized.

Copy link
Owner

commented May 22, 2019

Good. I need to ask one more thing.
Add this new config into exampleSite/config.toml just bellow custom_css.

mrozlukasz and others added some commits May 23, 2019

Update layouts/_default/baseof.html
Co-Authored-By: Luiz F. A. de Prá <luizdepra@users.noreply.github.com>
@mrozlukasz

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

All set. Thanks for the response and review.

@luizdepra luizdepra merged commit b54ec3d into luizdepra:master May 23, 2019

2 of 5 checks passed

Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
@luizdepra

This comment has been minimized.

Copy link
Owner

commented May 23, 2019

Thank you!

@mrozlukasz

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

No problem :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.