Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected multi language links #202

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@a1x42
Copy link
Contributor

commented Aug 4, 2019

Prerequisites

Put an x into the box(es) that apply:

  • [x ] This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

Description

correction of header partial to render the correct multi language URLs for main page and menu items including language prefix.

Issues Resolved

Before, the URL to sites in languages different to the default language needed the language prefix.
When in a non-default language the main link (i.e. click on title) always returned to the default language

Checklist

Put an x into the box(es) that apply:

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively
  • Reference issue with #<ISSUE_NO> if applicable

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already
a1x42
main link does not switch back to default language if in another lang…
…uage

no need to configure the language path in the different pages
@a1x42

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2019

NB, this is a great theme. Simple and easy to use! Great work.

@luizdepra

This comment has been minimized.

Copy link
Owner

commented Aug 5, 2019

Thank you!

@luizdepra luizdepra merged commit dea81ca into luizdepra:master Aug 5, 2019

2 of 5 checks passed

Header rules No header rules processed
Details
Pages changed 90 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
@a1x42

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

Sorry, I just noticed that the wiki also still needs updating at https://github.com/luizdepra/hugo-coder/wiki/Multilingual-Mode

url should not be with leading slash nor language e.g. replace url="/about/" by url="about/" and url="/pl/about/" by url="about/".

Also the last sentence should be removed: "In this case, remember to update your menus URLs (i.e. /en/about/)." It is wrong now.

Thanks for the merge.

@a1x42 a1x42 deleted the a1x42:bugfix-multi-language branch Aug 5, 2019

@luizdepra

This comment has been minimized.

Copy link
Owner

commented Aug 5, 2019

Sure. I think only I can change the wiki page.
I've created #203 to remember.

@a1x42

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.