Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust dark mode colorscheme #225

Merged
merged 2 commits into from Oct 9, 2019

Conversation

@ariejan
Copy link
Contributor

commented Oct 9, 2019

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

It fixes a "bug" where the inverted colorscheme was hard on the eyes with the bright whites, but having a beautiful dark-mode is a features 馃槃

Description

This PR makes the whites a bit softer and instead of inverting the blue hyperlinks to red, they're now desaturated - but still blue.

Before

Screenshot 2019-10-09 at 11 09 08

After

Screenshot 2019-10-09 at 11 10 07

Issues Resolved

I just fixed this for myself, feel free to pick it up.

Checklist

Put an x into the box(es) that apply:

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively
  • Reference issue with #<ISSUE_NO> if applicable

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Dit this, but I think the inverted theme is not generated automatically. This might be a separate bug.

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already
ariejan added 2 commits Oct 9, 2019
This makes the whites a bit softer and instead of
inverting the blue hyperlinks, they're now desaturated -
but still blue.
@luizdepra

This comment has been minimized.

Copy link
Owner

commented Oct 9, 2019

It really looks better with these changes. Thank you.

@luizdepra luizdepra merged commit fa3de1e into luizdepra:master Oct 9, 2019
2 of 5 checks passed
2 of 5 checks passed
Header rules No header rules processed
Details
Pages changed 90 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.