Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for type in social links #250

Merged
merged 2 commits into from Jan 13, 2020
Merged

Conversation

@anson-vandoren
Copy link
Contributor

anson-vandoren commented Jan 12, 2020

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

Description

Adds type attribute to social links (from config file) to allow for correct RSS links (which should have type=application/rss+xml

If social.params.type exists, add it to the generated link in the Home partial.

Example config.toml section

[[params.social]]
    name = "RSS"
    icon = "fas fa-rss fa-2x"
    weight = 7
    url = "https://example.com/posts/index.xml"
    rel = "alternate"
    type = "application/rss+xml"

See: https://developer.mozilla.org/en-US/docs/Archive/RSS/Getting_Started/Syndicating

Issues Resolved

List any existing issues this pull request resolves.

Checklist

Put an x into the box(es) that apply:

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively
  • Reference issue with #<ISSUE_NO> if applicable

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already
@luizdepra

This comment has been minimized.

Copy link
Owner

luizdepra commented Jan 13, 2020

Nice! Could you please add this new parameter into the exampleSite/config.toml?

https://github.com/luizdepra/hugo-coder/blob/master/exampleSite/config.toml#L58-L82

Copy link
Owner

luizdepra left a comment

Thank you.

@luizdepra luizdepra merged commit 4369ed7 into luizdepra:master Jan 13, 2020
5 checks passed
5 checks passed
Header rules No header rules processed
Details
Pages changed 3 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.