Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code block style of syntax highlighting #256

Merged
merged 1 commit into from Jan 31, 2020

Conversation

@josephting
Copy link
Contributor

josephting commented Jan 31, 2020

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

Description

Code blocks are taking up too much space.
This is an effort to optimize the layout.

Here's how it looked like before the changes.

Before

Here's a preview after the changes.

Preview

Please also make sure that the layout is fine by checking existing example posts.

Issues Resolved

Resolves #246.

Checklist

Put an x into the box(es) that apply:

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively
  • Reference issue with #<ISSUE_NO> if applicable

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already
@luizdepra

This comment has been minimized.

Copy link
Owner

luizdepra commented Jan 31, 2020

Woah! It looks very good now.
Thank you very much.

@luizdepra luizdepra merged commit 39616be into luizdepra:master Jan 31, 2020
5 checks passed
5 checks passed
Header rules No header rules processed
Details
Pages changed 91 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
@josephting josephting deleted the josephting:highlight-style branch Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.