Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rss.xml to layouts/_default #316

Merged
merged 6 commits into from Apr 28, 2020
Merged

Add rss.xml to layouts/_default #316

merged 6 commits into from Apr 28, 2020

Conversation

utkarsh2102
Copy link
Contributor

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

Description

Adds rss.xml to _default/ so that the entire content of the blog is achievable by the RSS feed.

Issues Resolved

Closes: #297

@clement-pannetier
Copy link
Contributor

I think the Netlify build error is due to to the hugo version.

@utkarsh2102
Copy link
Contributor Author

@clement-pannetier, hello again 👋
Should I bump the Hugo version in netlify.toml, too? :)

@clement-pannetier
Copy link
Contributor

@clement-pannetier, hello again 👋
Should I bump the Hugo version in netlify.toml, too? :)

I didn't do it when I made the PR for the new project archetype. I'm waiting for a response from @luizdepra.

@luizdepra
Copy link
Owner

As I said on @clement-pannetier's PR, there is no problem to bump the version since we use the minimal version.

#307 (comment)

@utkarsh2102
Copy link
Contributor Author

@clement-pannetier and @luizdepra, good to go now! 🚀 💯

@clement-pannetier
Copy link
Contributor

@clement-pannetier and @luizdepra, good to go now! 🚀 💯

Be carefull, you've forget to specify the hugo minimum version in the theme.toml file.

Also, why did you not set the latest version (0.69.2) ?

@utkarsh2102
Copy link
Contributor Author

Be carefull, you've forget to specify the hugo minimum version in the theme.toml file.

Right, I'll fix that.

Also, why did you not set the latest version (0.69.2) ?

Eh, I thought I don't want to use the latest (in case it breaks something somewhere at production or something).
Should I bump it to 0.69.2, really?

@luizdepra
Copy link
Owner

We should use the minimum working version. Shouldn't it be 0.55?

@clement-pannetier
Copy link
Contributor

We should use the minimum working version. Shouldn't it be 0.55?

Yes, but why settle for this old version. There are a lot of features that have been added since 0.55.
It's maybe the right time to upgrade 😃

@luizdepra
Copy link
Owner

Not really. If we are not using features exclusive from the newest version there is no need to use it.
I like to take the same approach of dependency management for library, where we declare minimal of other library that we need to our library work.

@utkarsh2102
Copy link
Contributor Author

@luizdepra, apparently 0.55.0 doesn't work :/

@luizdepra
Copy link
Owner

@utkarsh2102, looks like the base version for us is 0.57.0.

@utkarsh2102
Copy link
Contributor Author

@utkarsh2102, looks like the base version for us is 0.57.0.

Yay, that does the work! Good to go now? 🌮

@luizdepra
Copy link
Owner

Done. Thank you.

@luizdepra luizdepra merged commit e89ad7b into luizdepra:master Apr 28, 2020
@utkarsh2102
Copy link
Contributor Author

No, thank you for taking care of this and this amazing theme! ❤️

@clement-pannetier
Copy link
Contributor

@utkarsh2102, looks like the base version for us is 0.57.0.

Hi @luizdepra, why did you choose this version in particular ?

@luizdepra
Copy link
Owner

This is the oldest Hugo version with every feature we need to make this theme work.

@clement-pannetier
Copy link
Contributor

Yeah I mean, how ? You checked the releases on github, you tested it till the build process works... ?

@luizdepra
Copy link
Owner

Yeah, I check out these changes and I also used a tool called asdf-vm to control Hugo versions. With that I can easily install and change versions both globally or locally. So, I just have installed and tested every 0.X.0 version since 0.5.0, which was only 2. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable RSS for blogs?
3 participants