Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authors taxonomy for blog posts #435

Merged
merged 8 commits into from Oct 16, 2020

Conversation

earnestma
Copy link
Contributor

@earnestma earnestma commented Oct 11, 2020

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change. [?]

Description

Hi and thanks for this wonderful theme! This PR adds an "authors" taxonomy for blog posts. The person/ user icon shows before tags/categories, and can be browsed like any other taxonomy.

Here are some screenshots:
ss1

ss2

ss3

Configuration:

  • toml:
+++
authors = ["author 1", "author 2"]
+++
  • yaml:
---
authors: ["author 1"]
---

General

  • Added {{ with .Page.Params.Authors }}{{ partial "taxonomy/authors.html" . }}{{ end }} to layouts/posts/single.html
  • Added partial taxonomy/authors.html with the fa-user icon
  • Added en (English) string for author
  • Added authors to default post archetype
  • Added the taxonomy to the exampleSite config.toml file

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already

@luizdepra
Copy link
Owner

luizdepra commented Oct 13, 2020

Nice. Could you please add some authors to one or two post inside the exampleSite demo? That way we can see this new feature in action.

@earnestma
Copy link
Contributor Author

earnestma commented Oct 13, 2020

sure!

* Tested authors on pt-br and externally-linked post
* Also ran make release again
@@ -0,0 +1,126 @@
body.colorscheme-dark {
Copy link
Owner

@luizdepra luizdepra Oct 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've added these scss files by mistake. Please, remove the resources folder from inside exampleSite.
Also, there is a simple conflict to solve in CONTRIBUTORS.md.

Earnest Ma added 2 commits Oct 16, 2020
Fix merge conflict and remove resources folder
Deleted resources in exampleSite and added resources in root
@earnestma earnestma requested a review from luizdepra Oct 16, 2020
@luizdepra
Copy link
Owner

luizdepra commented Oct 16, 2020

Nicely done! Thanks.

@luizdepra luizdepra merged commit e26616e into luizdepra:master Oct 16, 2020
5 checks passed
@clement-pannetier clement-pannetier mentioned this pull request Oct 18, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants