Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long title covers menu #574

Merged
merged 6 commits into from Jun 25, 2021
Merged

Conversation

kuba86
Copy link
Contributor

@kuba86 kuba86 commented May 11, 2021

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

Description

  • makes navigation-list and menu-button position relative, so when browsing a site on mobile phone, it is possible to click on the menu when title page is long and spans multiple lines.
  • adds margin to .container for aesthetics
  • removes line-height: 6rem; from navigation's a tag which blocks menu button when page title is long

Issues Resolved

#573

Checklist

Put an x into the box(es) that apply:

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively
  • Reference issue with #<ISSUE_NO> if applicable

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already

@luizdepra
Copy link
Owner

Thank you for contributing.

Well, there is a problem. The title is miss aligned inside the header.

miss_aligned

Could you please fix this problem?

@kuba86
Copy link
Contributor Author

kuba86 commented May 11, 2021

@luizdepra thanks for the review, made the changes. Title is align with menu button now.

@kuba86
Copy link
Contributor Author

kuba86 commented Jun 20, 2021

@luizdepra hey, let me know if there is anything outstanding.

@luizdepra
Copy link
Owner

Sorry for taking so long to come back here. Work is using all my energies this year.

Well, this PR looks fine now. So, thank you. :)

@luizdepra luizdepra merged commit afa17c8 into luizdepra:master Jun 25, 2021
@kuba86 kuba86 deleted the long-title-covers-menu branch June 29, 2021 13:18
RobbiNespu pushed a commit to RobbiNespu/hugo-coder that referenced this pull request Jul 21, 2022
* modified margin for .container class

* modified navigation list and menu button so it is relative to title

* added kuba86 as contributor

* generate CSS files

* remove margin-top from menu-button to align with title inside navigation

Co-authored-by: Luiz F. A. de Prá <luizdepra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants