New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset pipeline #65
Asset pipeline #65
Conversation
I still need to create a make rule to generate the style files. |
I might be able to test RTL out, but fist I need to understand how SCSS works in the first place! |
I checked the modified files and i'm curious about the advantages of changing for SCSS? On the code it's not that clear. (It's not a critic at all, more for my personal knowledge ^^). |
@rdhox, about the language, SCSS/SASS is more used than LESS. In fact, they are quite similar. |
Thanks for your answer, I understand now. I will try to test some features as soon as I can, but I unfortunately broke my wrist recently... So I'm afraid i'm not gonna be a great help in a near future :/ |
These changes seem ok so far. Merging soon. |
ad87fa4
to
673dc90
Compare
Finally I got the time to test this new Pipeline feature. It's so cool! I'm still playing around with it, and most probably will open a PR soon to move |
Well, with Asset Pipeline is possible to use RTL or inverted colors by just overriding the SCSS files. But, we can also try the I just don't want to create lots of styling options (via theme configuration) that can be achieved by overriding style files. Inverted Colors is one of these cases. You just need to override |
That's generally true, specially for inverted colors, but most probably will not work for RTL, because most people (including myself) who eventually need this, will end up with two languages on the site one being LTR the other being RTL. and technically we cannot have one final css for both, that's why I think adding a config to theme (the same as before, |
Understood. How about creating a base CSS class, |
Yes, that's exactly what I had in mind, similar to what there was in v1.0 |
* Add avatar option and footer text option (luizdepra#41) * Add avatar option and footer text option * add responsive avatar for narrow screen * improvement of code * conflicts solved * Add support for multilingualism (luizdepra#40) * Improve README.md * Mobile menu (luizdepra#63) * mobile menu functional * mobile menu beta * edits mobile-menu: home link out, rtl ok, menu pop over * mobile menu - bugs correction * add horizontal separator * corrections done + add configuration of centered or rtl/ltr mobile menu * edit config of example * separator padding full * Update logos and screenshots * Add style enhancements for AsciiDoc (luizdepra#67) * Add SCSS via Asset Pipeline (luizdepra#65) * Remove old files * Add SCSS pipeline * Add generated files * Fix navigation HTML * Fix media queries * Remove RTL * Fix styling for big screens * Remove separator configs * Fix menu dropdown * Add working mobile menu * Fix menu item heights * Update README * Improve README. * Remove resources folder * Add social icons * Enable RTL layout by providing 'rtl = true' in the config (luizdepra#72) * Use Hugo asset pipelines
I have chaged all styling code to SCSS, using the new Hugo's Asset Pipeline.
I need help testing here.
Closes #52 .