Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct regression with code highlighting in dark mode #760

Merged
merged 3 commits into from Jan 10, 2023

Conversation

robertwtucker
Copy link
Contributor

@robertwtucker robertwtucker commented Jan 8, 2023

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

Description

This PR reverts a regression error in which the foreground color specified for highlighted code is almost indistinguishable from the white background used in dark mode.

This was originally fixed in 29a7a94 / #630 by assigning color: $fg-color from the light scheme variables (resolves to #212121). In 476429d, the assignment was changed to $fg-color-dark (resolves to #dadada) but this resulted in a color that is too close to the white of the code highlight to be read easily. See image:

SCR-20230107-rqc

This fix assigns $bg-color-dark which resolves to #212121 (same as the original fix). With this change applied, the code is now legible:

SCR-20230107-rol

Issues Resolved

N/A

Checklist

Put an x into the box(es) that apply:

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively
  • Reference issue with #<ISSUE_NO> if applicable

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already

@luizdepra
Copy link
Owner

I will accept this, but I fear that using a different option of code highlight colors could result in the same problem. Let's see.

@luizdepra luizdepra merged commit 6407a20 into luizdepra:main Jan 10, 2023
@robertwtucker robertwtucker deleted the patch-1 branch January 11, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants