fix: correct regression with code highlighting in dark mode #760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Put an
x
into the box(es) that apply:Description
This PR reverts a regression error in which the foreground color specified for highlighted code is almost indistinguishable from the white background used in dark mode.
This was originally fixed in 29a7a94 / #630 by assigning
color: $fg-color
from the light scheme variables (resolves to#212121
). In 476429d, the assignment was changed to$fg-color-dark
(resolves to#dadada
) but this resulted in a color that is too close to the white of the code highlight to be read easily. See image:This fix assigns
$bg-color-dark
which resolves to#212121
(same as the original fix). With this change applied, the code is now legible:Issues Resolved
N/A
Checklist
Put an
x
into the box(es) that apply:General
#<ISSUE_NO>
if applicableResources
make release
to regenerate all CSS filesContributors
CONTRIBUTORS.md
if you aren't on it already