New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Makefile and netlify deployment #91

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@khos2ow
Copy link
Contributor

khos2ow commented Oct 4, 2018

This PR enhances "deploy preview" on Netlify and Makefile targets.

Fixes #79

@khos2ow khos2ow force-pushed the khos2ow:netlify branch from 2295023 to 5290e8e Oct 4, 2018

@khos2ow khos2ow changed the title WIP: Enhance Makefile and netlify deployment Enhance Makefile and netlify deployment Oct 4, 2018

@khos2ow khos2ow force-pushed the khos2ow:netlify branch from 5290e8e to ce1303e Oct 4, 2018

Makefile Outdated
@@ -1,17 +1,18 @@
.PHONY: release build demo clean

This comment has been minimized.

@luizdepra

luizdepra Oct 4, 2018

Owner

You need to add prepare here.

This comment has been minimized.

@khos2ow

khos2ow Oct 4, 2018

Contributor

Right, good catch!

command = "make prepare && hugo --source demo"

[context.deploy-preview]
command = "make prepare && hugo --source demo --buildFuture --buildDrafts --baseURL $DEPLOY_PRIME_URL"

This comment has been minimized.

@luizdepra

luizdepra Oct 4, 2018

Owner

We need to add the HUGO_VERSION in this file too.

This comment has been minimized.

@khos2ow

khos2ow Oct 4, 2018

Contributor

done.

@khos2ow khos2ow force-pushed the khos2ow:netlify branch from ce1303e to 2380657 Oct 4, 2018

@luizdepra luizdepra merged commit dcefc20 into luizdepra:master Oct 4, 2018

1 check passed

deploy/netlify Deploy preview ready!
Details

@khos2ow khos2ow deleted the khos2ow:netlify branch Oct 4, 2018

@luizdepra

This comment has been minimized.

Copy link
Owner

luizdepra commented Oct 4, 2018

Thank you. I had to add some extra configuration into netlify.toml but everything is working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment