Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needless fn #8

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@thomasmulvaney
Copy link
Contributor

commented Apr 1, 2019

Hi @luizirber, thanks for making me aware of const fn. Having looked through docs a bit, it seems that you can probably just go about constructing the const arrays without the help of any extra const fn.

@codecov

This comment has been minimized.

Copy link

commented Apr 1, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@81f0c37). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   62.89%           
=========================================
  Files             ?        3           
  Lines             ?      159           
  Branches          ?        0           
=========================================
  Hits              ?      100           
  Misses            ?       59           
  Partials          ?        0
Impacted Files Coverage Δ
src/lib.rs 56.31% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81f0c37...3fb07aa. Read the comment docs.

@luizirber

This comment has been minimized.

Copy link
Owner

commented Apr 1, 2019

Indeed, thanks @thomasmulvaney !

@luizirber luizirber merged commit ad2fddf into luizirber:master Apr 1, 2019

3 checks passed

codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.