Bug on rename using shift A

[jt6677]

BUG:
Activate rename, type A (shift+a) would 'disable' enter to save.

how to replicate the issue:
In your rename example, rename and type a single A. The enter to save is disabled.
But if you type AA, you can save again.

type A would result the hotkey log to be this

HOTKEYS
Set [ "Shift", "A" ]

HOTKEYS
Set [ "A", " " ]

HOTKEYS
Set [ "A", "s" ]

HOTKEYS
Set [ "A", "d" ]

HOTKEYS
Set [ "A", "s" ]

HOTKEYS
Set [ "A", "Enter" ]

System:
win 10
Browser: firefox\Brave\Chrome

[jt6677]

it is even more problematic with none-English. Typing Chinese would log 'Process'

HOTKEYS
Set(3) [ "Process", "C", "a" ]

Set(4) [ "Process", "C", "a", "s" ]

HOTKEYS
Set(5) [ "Process", "C", "a", "s", "d" ]

HOTKEYS
Set(5) [ "Process", "C", "s", "d", " " ]

HOTKEYS
Set(4) [ "Process", "C", " ", "a" ]

HOTKEYS
Set(5) [ "Process", "C", " ", "a", "s" ]

HOTKEYS
Set(6) [ "Process", "C", " ", "a", "s", "d" ]

HOTKEYS
Set(3) [ "Process", "C", "Enter" ]

[jt6677]

I could call the tree.completeRename() on the input. But the rest of hotkeysCoreFeature would be broken until page refresh.

[lukasbach]

Thanks for your report! I've implemented a fix in 1.0.1, the issue should hopefully not happen anymore.

[jt6677]

"Process" key event from typing Chinese is still a problem.

[jt6677]

Maybe disable key listen on input and let user to pass in onKeyDown or onBlur. 'Esc' to cancel tricked me up from time to time anyway.

[lukasbach]

Hm okay, I'll have another look then.

[lukasbach]

I've did some more changes. I'm having a hard time to improve this since I don't have a keyboard with the keys to reproduce this, but maybe the new changes where able to help with this. I've published the fix in version 0.0.0-20250508233207 for now. I've also added a config option ignoreHotkeysOnInputs that is disabled by default, but can be enabled if you want to disable listening to any keys while input elements are focused.

[lukasbach]

I noticed another issue that also related to what you reported, any changed a core implementation detail relating to hotkey handling, I have fairly good feeling that this should also resolve your issue, if you haven't tested it yet, the improved behavior is available on snapshot version 0.0.0-20250511194715.

[jt6677]

I searched the npm versions several times in the past few days. I am not sure why "pnpm view @headless-tree/core versions" is not showing the version you mentioned.