Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FTP with SSL support #62

Merged
merged 3 commits into from Oct 22, 2016

Conversation

Projects
None yet
4 participants
@hajekj
Copy link
Collaborator

commented May 30, 2016

This option is required in order to have FTP with SSL support.

Fixes #30

Enable FTP with SSL support
This option is required in order to have FTP with SSL support.
@lukasz-wronski

This comment has been minimized.

Copy link
Owner

commented Jun 26, 2016

@hajekj Hi, thank you for a pull request. It's very helpful for me that you are engaged in this project too. What I'd like to ask you is to apply to your fix the same indentation as in original file. Right now I cant really check what was changed because it looks like the whole file was rewritten.

@hajekj

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 26, 2016

Generally, I think that the formatting is screwed up in the file, all that was changed is following:

  1. Added secure: false, to defaultConfig
  2. Added secure: config.secure, to getSyncConfig
@Nighthawk22

This comment has been minimized.

Copy link

commented Aug 2, 2016

Hi @hajekj
This pull request is really helpfull. Changed my local files according to your pull request.
It would also be really awesome to add the secureOptions option so you could also ignore invalid certs.

@hajekj

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 3, 2016

@Nighthawk22 That is a great idea, I will see about adding that into this PR.

@michalhudecek

This comment has been minimized.

Copy link

commented Oct 21, 2016

@hajekj @lukasz-wronski Can you please finish this pull request? I see it's just a small change. It would be very helpful! Thanks a lot.

@hajekj

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 21, 2016

Sorry, don't have permissions on the repo.

@michalhudecek

This comment has been minimized.

Copy link

commented Oct 21, 2016

@lukasz-wronski Can't you give permissions to someone else as well? The latest update of this repo is from June :( It's a pitty.

@michalhudecek
Copy link

left a comment

This should be easy to merge.

@hajekj

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 21, 2016

We could fork the repo and make our own official release from this.. As a plan B

@michalhudecek

This comment has been minimized.

Copy link

commented Oct 22, 2016

Lukasz is looking for collaborators #96. I think you can just ask him to get access

@hajekj hajekj merged commit 81a55b5 into lukasz-wronski:master Oct 22, 2016

@hajekj hajekj referenced this pull request Oct 22, 2016

Closed

FTPS (FTP over SSL) support #30

hajekj added a commit that referenced this pull request Oct 22, 2016

@hajekj hajekj referenced this pull request Oct 24, 2016

Closed

More like a question. #56

@lukasz-wronski

This comment has been minimized.

Copy link
Owner

commented Oct 25, 2016

#96

pt., 21.10.2016, 23:46 użytkownik Jan Hajek notifications@github.com
napisał:

We could fork the repo and make our own official release from this.. As a
plan B


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#62 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APOGWDixZe4p7fJlQ0_wq81DEQd7fLbwks5q2TKvgaJpZM4Ip9KO
.

@ecabigting ecabigting referenced this pull request Dec 5, 2017

Open

FTPS support #209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.