added a better error message and a link to a full explanation #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endor
reviewed
Aug 6, 2019
endor
reviewed
Aug 6, 2019
endor
reviewed
Aug 6, 2019
endor
reviewed
Aug 6, 2019
endor
reviewed
Aug 6, 2019
endor
reviewed
Aug 6, 2019
| @@ -40,6 +40,12 @@ export class GetTestController extends Controller { | |||
| modelsArray: new Array<TestSubModel>(), | |||
| numberArray: [1, 2, 3], | |||
| numberValue: 1, | |||
| object: { | |||
There was a problem hiding this comment.
are these necessary for the tests to compile?
There was a problem hiding this comment.
Yea, unfortunately they are necessary for the tests to compile. It happened because one of the previous PRs got merged without the tests running (woops!). But now that the previous PR added husky, these kind of things will be caught.
|
@endor I pushed the corrections. Thank you so much for reviewing this so thoroughly. It's wonderful to be collaborating with you. :) |
endor
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #384