Skip to content

Luke Baker lukebaker

Organizations

All Our Ideas Agathon Group
Luke Baker
Luke Baker
  • Luke Baker ebaefd2
    ensure error responses are JSON for JS requests
Luke Baker
Luke Baker
  • Luke Baker 5956202
    Separate algorithm data into two columns.
Luke Baker
Better ajax error messages
4 commits with 65 additions and 14 deletions
Luke Baker
Luke Baker
  • Luke Baker 573f3bf
    Airbrake ignore ActionController::MethodNotAllowed
Luke Baker
  • Luke Baker 1b5fee0
    fix algorithm JSON test for good this time
Luke Baker
  • Luke Baker 5523d14
    Update tests to account for JSON data for algo.
Luke Baker
Luke Baker
Luke Baker
Deadlock retries
4 commits with 53 additions and 21 deletions
Luke Baker
Record prompt algo
2 commits with 37 additions and 2 deletions
Luke Baker
  • Luke Baker 9652e2f
    move location where we set prompt.algorithm
lukebaker commented on pull request allourideas/pairwise-api#32
Luke Baker

Sure enough. :+1: Thanks!

Luke Baker
  • Luke Baker f4546cb
    further simplify get_first_unanswered_appearance
lukebaker commented on pull request allourideas/pairwise-api#32
Luke Baker

Thanks, Joel. I've made some changes based on your suggestions.

lukebaker commented on pull request allourideas/pairwise-api#32
Luke Baker

Yes, that makes things a bit simpler. Good call. I've added that after verifying it causes no additional DB queries.

lukebaker commented on pull request allourideas/pairwise-api#32
Luke Baker

Agreed about consolidating the raise. I find the unless operator confusing in all but simplest conditions, so I opted for altering the if / else to…

Luke Baker
  • Luke Baker e35aa8f
    clean up create_or_find_next_appearance
lukebaker commented on pull request allourideas/pairwise-api#32
Luke Baker

We are only seeing deadlocks in the call to record_appearance, but the whole transaction is being rescued because we need to retry the entire trans…

Luke Baker
Deadlock retries
2 commits with 52 additions and 21 deletions
Luke Baker
  • Luke Baker c168741
    refactor appearance creation to a single method
Luke Baker
Luke Baker
Something went wrong with that request. Please try again.