Skip to content

Luke Bakken
lukebakken

Organizations

@basho @uidaho-bsn
@lukebakken

I can't reproduce this issue, and you can see in the integration test suite that Delete is tested. I just re-ran that test locally and it succeeded. …

@lukebakken
@lukebakken
lukebakken commented on pull request basho/riak-go-client#48
@lukebakken

The changes here were the main fix to the bug. Previously, while iterating through the pool to find an available connection, if the connection were…

lukebakken commented on pull request basho/riak-go-client#48
@lukebakken

Without checking if the error is for a temporary network error (like read / write timeout), the connection was marked connInactive which would caus…

lukebakken commented on pull request basho/riak-go-client#48
@lukebakken

This will show executed commands with a unique suffix in the debug output which makes it easier to correlate log lines.

lukebakken commented on pull request basho/riak-go-client#48
@lukebakken

Note: the "test" is the fact that this executes without error. Before fixing the bugs in the code, this test would either panic or error out.

lukebakken commented on pull request basho/riak-go-client#48
@lukebakken

Hi @pguelpa - I reproduced the issue and am pretty sure have it fixed if you'd like to test this branch again. Let me know how it goes ... thanks! :fish_cake:

@lukebakken
  • @lukebakken 97f8f28
    Health check simplification, fix new test
@lukebakken

Hello - Can you please be more specific about "doesn't work"? Does the object remain in Riak, and/or do you get an error at that point? If the obje…

@lukebakken
  • @lukebakken 504799f
    Fix default min connections
@lukebakken
  • @lukebakken ce6bdf4
    Found one bug contributing to GH-47
@lukebakken
@lukebakken
  • @lukebakken a573bbb
    Add to GH-47 test program
@lukebakken
@lukebakken
  • @lukebakken acd0f98
    Add function to store data
@lukebakken
@lukebakken
  • @lukebakken 87da7e0
    Add GH-47 test application.
@lukebakken
@lukebakken
  • @lukebakken e388532
    connectionManager get will create a connection if the current count i…
lukebakken closed pull request basho/riak-go-client#50
@lukebakken
After expiring connections ensure there are at least minConnections available
lukebakken commented on pull request basho/riak-go-client#50
@lukebakken

I have added your commit to #48 - thank you.

@lukebakken
@lukebakken
  • @lukebakken 35361bf
    If RIAK_GO_CLIENT_DEBUG env var is set to any value, set EnableDebugL…
lukebakken commented on pull request basho/riak-go-client#48
@lukebakken

That's exactly what would happen. Let me improve this. Aren't code reviews grand? :smile:

lukebakken commented on pull request basho/riak-go-client#48
@lukebakken

@pguelpa - how about this for a fix to #49? If the node needs a new connection and the current count is less than the minimum, just go ahead and cr…

@lukebakken
  • @lukebakken 7d163a7
    connectionCounter changes to use embedded mutex
@lukebakken
  • @lukebakken 42b92f0
    Add code to give commands a unique name when EnableDebugLogging is true.
Something went wrong with that request. Please try again.