New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock the service if no API key exists #69

Closed
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@choroba
Contributor

choroba commented Dec 6, 2015

Test at least the basic functionality even when the service isn't accessible.
(First 38 tests from live.t implemented. I originally had the first 112, but it was fragile, and there's no point in reimplementing Stripe again.)

@choroba

This comment has been minimized.

Show comment
Hide comment
@choroba

choroba Dec 6, 2015

Contributor

Two new dependencies added to tests: parent and Test::LWP::UserAgent.

Contributor

choroba commented Dec 6, 2015

Two new dependencies added to tests: parent and Test::LWP::UserAgent.

Better object wrapping
- don't change the underlying Test::LWP::UserAgent, wrap it
- coderef already supported as the 2nd argument to map_response
@choroba

This comment has been minimized.

Show comment
Hide comment
@choroba

choroba Dec 31, 2015

Contributor

parent no longer needed.

Contributor

choroba commented Dec 31, 2015

parent no longer needed.

use clause moved to the top
- AUTOLOAD more readable
@choroba

This comment has been minimized.

Show comment
Hide comment
@andrewsolomon

This comment has been minimized.

Show comment
Hide comment
@andrewsolomon

andrewsolomon Apr 29, 2017

Collaborator

@choroba thanks for putting in a huge effort - and an interesting article to boot! As of last week I've taken on the job of managing this package's CPAN releases and I promise that I'll run the end-to-end tests using my private key before accepting any pull requests.

On these grounds I'll say thanks, but no thanks because I think that it will be a lot of work to maintain this code as Stripe releases its new versions and its backward compatible changes (which it is still making to very old versions).

Thanks again,

Andrew

p.s If you'd still like to improve the testing on this package I'd feel more comfortable with extensive integration tests (tests against live).

Ideally this would be a test against each version of the API by putting the version in the header of the tests' requests https://stripe.com/docs/api#versioning

Collaborator

andrewsolomon commented Apr 29, 2017

@choroba thanks for putting in a huge effort - and an interesting article to boot! As of last week I've taken on the job of managing this package's CPAN releases and I promise that I'll run the end-to-end tests using my private key before accepting any pull requests.

On these grounds I'll say thanks, but no thanks because I think that it will be a lot of work to maintain this code as Stripe releases its new versions and its backward compatible changes (which it is still making to very old versions).

Thanks again,

Andrew

p.s If you'd still like to improve the testing on this package I'd feel more comfortable with extensive integration tests (tests against live).

Ideally this would be a test against each version of the API by putting the version in the header of the tests' requests https://stripe.com/docs/api#versioning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment