Skip to content

Luke Carbis lukecarbis

Organizations

WP e-Commerce
Luke Carbis
Luke Carbis

:thumbsup:

Luke Carbis
  • Luke Carbis 70167e3
    Use esc_sql instead of ->esc_like for back-compat
Luke Carbis
  • Luke Carbis f46151f
    Remove another like_escape
Luke Carbis
  • Luke Carbis 5ee4b84
    Remove usage of like_escape
Luke Carbis

Yes, but that was when the input was just text. The validation is still occurring here.

Luke Carbis
lukecarbis commented on pull request x-team/wp-stream#563
Luke Carbis

@fjarrett This was already kind of working, only it was using a dropdown (with custom input when you clicked the dropdown) because we were only all…

Luke Carbis
lukecarbis commented on pull request x-team/wp-stream#563
Luke Carbis

(Oops! Edited.) AWESOME Thanks @westonruter. /five

lukecarbis commented on pull request x-team/wp-stream#563
Luke Carbis

@weston That seems to have helped! But now we get a new (PHPCS) error: the "WordPress:core-extra" coding standard is not installed. The installed c…

Luke Carbis
lukecarbis deleted branch issue-591 at x-team/wp-stream
Luke Carbis
lukecarbis merged pull request x-team/wp-stream#592
Luke Carbis
Fix action key for comment Throttled label
1 commit with 1 addition and 1 deletion
Luke Carbis
Fix action label for comment throttling
lukecarbis commented on pull request x-team/wp-stream#592
Luke Carbis

:thumbsup:

lukecarbis commented on pull request x-team/wp-stream#563
Luke Carbis

I have always had to remove these lines from phpcs.ruleset otherwise everything fails without an error, but once I do that, the unit tests run perf…

Luke Carbis
  • Luke Carbis e98c139
    Fix bug effecting select all rows checkbox
lukecarbis commented on pull request x-team/wp-stream#563
Luke Carbis

Good find @fjarrett. I realised that I was re-attaching events to existing rows when adding a new row. I also stopped attaching events to hidden ro…

Luke Carbis
  • Luke Carbis a3bc706
    Fix small bug, and speed things up a lot.
lukecarbis commented on pull request x-team/wp-stream#563
Luke Carbis

^ No idea why Travis is failing. Call Stack says it's running wp_not_installed()... which I think it a bit weird, and then it runs the shutdown act…

Luke Carbis
  • Luke Carbis 7c2b523
    Empty commit, to make Travis feel better
lukecarbis commented on pull request x-team/wp-stream#563
Luke Carbis

Fixed in 101a728.

Luke Carbis
  • Luke Carbis 101a728
    Fix js error causing context not persisting on save
lukecarbis commented on pull request x-team/wp-stream#563
Luke Carbis

Code is committed Ready for review again Travis is happy

Luke Carbis

@shadyvb You'll probably want to take a look at what I did here. We're going to stop logging contexts and actions with array( $context => $action ),…

Luke Carbis
  • Luke Carbis 21b7359
    Switch to string context method
Luke Carbis
Check if comments are open before enabling inline comments
1 commit with 8 additions and 0 deletions
Something went wrong with that request. Please try again.