From f78ce131009326842d6d64aab8cc41bc2f8036ac Mon Sep 17 00:00:00 2001 From: Luke Carr Date: Thu, 21 May 2020 14:58:06 +0100 Subject: [PATCH] refactor(got): hTTP requests now use qs to generate query strings --- package-lock.json | 11 +++++++++++ package.json | 4 +++- src/modules/index.ts | 7 ++++--- 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index 0e6ad80..2f00979 100644 --- a/package-lock.json +++ b/package-lock.json @@ -3149,6 +3149,12 @@ "integrity": "sha512-/rM+sWiuOZ5dvuVzV37sUuklsbg+JPOP8d+nNFlo2ZtfpzPiPvh1/gc8liWOLBqe+sR+ZM7guPaIcTt6UZTo7Q==", "dev": true }, + "@types/qs": { + "version": "6.9.3", + "resolved": "https://registry.npmjs.org/@types/qs/-/qs-6.9.3.tgz", + "integrity": "sha512-7s9EQWupR1fTc2pSMtXRQ9w9gLOcrJn+h7HOXw4evxyvVqMi4f+q7d2tnFe3ng3SNHjtK+0EzGMGFUQX4/AQRA==", + "dev": true + }, "@types/responselike": { "version": "1.0.0", "resolved": "https://registry.npmjs.org/@types/responselike/-/responselike-1.0.0.tgz", @@ -15251,6 +15257,11 @@ "integrity": "sha1-fjL3W0E4EpHQRhHxvxQQmsAGUdc=", "dev": true }, + "qs": { + "version": "6.9.4", + "resolved": "https://registry.npmjs.org/qs/-/qs-6.9.4.tgz", + "integrity": "sha512-A1kFqHekCTM7cz0udomYUoYNWjBebHm/5wzU/XqrBRBNWectVH0QIiN+NEcZ0Dte5hvzHwbr8+XQmguPhJ6WdQ==" + }, "quick-lru": { "version": "4.0.1", "resolved": "https://registry.npmjs.org/quick-lru/-/quick-lru-4.0.1.tgz", diff --git a/package.json b/package.json index 96e43e1..80584b0 100644 --- a/package.json +++ b/package.json @@ -57,6 +57,7 @@ "@semantic-release/git": "^9.0.0", "@types/jest": "^25.2.3", "@types/node": "^14.0.4", + "@types/qs": "^6.9.3", "@typescript-eslint/eslint-plugin": "^2.34.0", "@typescript-eslint/parser": "^2.34.0", "codecov": "^3.7.0", @@ -80,7 +81,8 @@ }, "dependencies": { "@babel/runtime": "^7.9.6", - "got": "^11.1.4" + "got": "^11.1.4", + "qs": "^6.9.4" }, "config": { "commitizen": { diff --git a/src/modules/index.ts b/src/modules/index.ts index 613f321..92ce838 100644 --- a/src/modules/index.ts +++ b/src/modules/index.ts @@ -1,3 +1,4 @@ +import qs from "qs"; import { Client } from "../client"; import FunctionResponse from "../functions/response"; @@ -38,10 +39,10 @@ export default abstract class Module { searchParams?: any ): Promise { const response = await this.client.got.get("webservice/rest/server.php", { - searchParams: { + searchParams: qs.stringify({ wsfunction, - ...searchParams, - }, + ...searchParams + }), responseType: "json", });