Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose client to allow unref for #12 #16

Closed
wants to merge 2 commits into from

Conversation

@bahmutov
Copy link

bahmutov commented Apr 27, 2018

Now you can do something like this to avoid preventing Node process from exiting

const Keyv = require('keyv')
const keyv = new Keyv(process.env.REDIS_URL)
keyv.opts.store.client.unref()
bahmutov added 2 commits Apr 27, 2018
@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 27, 2018

Coverage Status

Coverage increased (+0.2%) to 93.333% when pulling b64f44c on bahmutov:master into 2d0ae9f on lukechilds:master.

@lukechilds

This comment has been minimized.

Copy link
Owner

lukechilds commented Apr 30, 2018

Thanks for taking the time to put a PR together but I don't want to encourage using the client directly. Any API methods we expose should be exposed via Keyv and abstracted across storage adapters.

More info in this comment: #12 (comment)

@lukechilds lukechilds closed this Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.