New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom keyboard shortcut, zoom vs font-size #15

Open
getify opened this Issue Jan 6, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@getify
Copy link

getify commented Jan 6, 2019

The keyboard shortcut for zooming is ⌘ +, which makes sense. However, that actually requires (on most US keyboards anyway) a ⌘ ⇧ + keypress, because + is on the upper portion of the = key. Most editors I've worked with actually allow just ⌘ = as well. This would be very helpful.


Also, the "zoom" behavior of this operation feels a bit weird:

runjs-zooming

It's strange and a bit frustrating that the zooming is also changing the spacing around the text. I would expect zooming to only affect the text... in other words, like in Sublime, when you do CMD +, it just ups the font size by a point, and CMD - drops the font size by a point. The zoom/unzoom don't change any of the UI layout/positioning, only the content text.

Also, it might be helpful if we could independently "zoom" the scratch area from the console output area, similar to how in Chrome the devtools has a zoom that's independent of the page's zoom.

@lukehaas

This comment has been minimized.

Copy link
Owner

lukehaas commented Jan 8, 2019

Thanks for raising this.
Firstly, I will add the CMD = shortcut for zooming.

Regarding your second point, only increasing the font-size on zoom seems to make sense, especially as the UI is very minimal.
My only concern would be if some users, possibly ones with sight issues, would expect a full UI zoom.

@getify

This comment has been minimized.

Copy link

getify commented Jan 8, 2019

My only concern would be if some users, possibly ones with sight issues, would expect a full UI zoom.

That concern is understandable, but I think there are generally other OSX A11Y tools they can use in those cases.

@lukehaas lukehaas added the enhancement label Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment