setRoute broken because of missing this

lukemorton · Nov 30, 2011 · 8dd89a1 · 8dd89a1
1 parent 7f14d24
commit 8dd89a1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/director/browser.js b/lib/director/browser.js
@@ -112,7 +112,7 @@ var listener = {
 
   setHash: function (s) {
     // Mozilla always adds an entry to the history
-    if (mode === 'legacy') {
+    if (this.mode === 'legacy') {
       this.writeFrame(s);
     }
 

diff --git a/test/browser/routes-test.js b/test/browser/routes-test.js
@@ -614,3 +614,19 @@ createTest('functions should have |this| context of the router instance.', {
     this.finish();
   });
 });
+
+createTest('setRoute with a single parameter should change location correctly', {
+  '/bonk': {
+    on: function() {
+      shared.fired.push(window.location.hash);
+    }
+  }
+}, function() {
+  var self = this;
+  shared.fired = [];
+  this.router.setRoute('/bonk');
+  setTimeout(function() {
+    deepEqual(shared.fired, ['#/bonk']);
+    self.finish();
+  }, 14)
+});