Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyphen in keys #27

Open
daverickdunn opened this issue Aug 13, 2018 · 3 comments
Open

Hyphen in keys #27

daverickdunn opened this issue Aug 13, 2018 · 3 comments

Comments

@daverickdunn
Copy link

Using a hyphen in the object key names doesn't play very well with JavaScript and other languages. Please consider using underscores or camelCase.

@lukes
Copy link
Owner

lukes commented Aug 15, 2018

Thanks for your comment.

I agree. I'm tempted to go with underscores, just because one of the keys is iso_3166-2, and camelized it would become iso31662.

What do you think?

@andrerpena
Copy link

I would prefer camelCase like "countryCode" but snake case, as proposed, for me, is better than kebab case.

@jsejcksn
Copy link

jsejcksn commented Nov 4, 2019

Snake case matches CSV heading data from ISO (noted in #31), and using a uniform whitespace character (snake_case) provides for a simpler conversion process than not using one (camelCase).

iso_3166-2 current
iso31662 camel
iso_3166_2 snake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants