Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows-terminal: Add version 0.6.2951.0 #3054

Merged
merged 5 commits into from Dec 6, 2019
Merged

windows-terminal: Add version 0.6.2951.0 #3054

merged 5 commits into from Dec 6, 2019

Conversation

Bassetts
Copy link
Contributor

@Bassetts Bassetts commented Oct 23, 2019

Adds Windows Terminal

Install script and autoupdate regex adapted from the unofficial chocolatey package.

bucket/windows-terminal.json Outdated Show resolved Hide resolved
bucket/windows-terminal.json Outdated Show resolved Hide resolved
bucket/windows-terminal.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version works with extraction without any major issue. (Ash258/Shovel-Ash258#45)

See fixed manifest

Fixed manifest
{
    "version": "0.6.2951.0",
    "description": "The new Windows Terminal, and the original Windows console host in one place.",
    "homepage": "https://github.com/microsoft/terminal",
    "license": "MIT",
    "url": "https://github.com/microsoft/terminal/releases/download/v0.6.2951.0/Microsoft.WindowsTerminal_0.6.2951.0_8wekyb3d8bbwe.msixbundle#/cosi.7z",
    "hash": "1e55cd46043ad5613242aae3bceb528b81a181a8b388015ebe7767000102d06a",
    "architecture": {
        "64bit": {
            "pre_install": "Get-ChildItem $dir -Exclude '*x64.msix' | Remove-Item -Force -Recurse"
        },
        "32bit": {
            "pre_install": "Get-ChildItem $dir -Exclude '*x86.msix' | Remove-Item -Force -Recurse"
        }
    },
    "installer": {
        "script": "Get-ChildItem $dir '*.msix' | Select-Object -ExpandProperty Fullname | Expand-7zipArchive -DestinationPath $dir -Removal"
    },
    "bin": "WindowsTerminal.exe",
    "shortcuts": [
        [
            "WindowsTerminal.exe",
            "Windows Terminal"
        ]
    ],
    "checkver": {
        "url": "https://github.com/microsoft/terminal/releases",
        "regex": "WindowsTerminal_([\\d.]+)_(?<hash>[\\w]+)\\.msix"
    },
    "autoupdate": {
        "url": "https://github.com/microsoft/terminal/releases/download/v$version/Microsoft.WindowsTerminal_$version_$matchHash.msixbundle#/dl.7z"
    }
}

If you insist on os validation add it into installer script

@Ash258 Ash258 changed the title windows-terminal: add windows terminal app windows-terminal: Add version 0.6.2951.0 Oct 24, 2019
@Ash258
Copy link
Contributor

Ash258 commented Oct 24, 2019

@r15ch13 Maybe this could go into Main as it is simillar to cmder and other terminals?

@Bassetts
Copy link
Contributor Author

@Ash258 I wasn't sure this would be eligible for Main yet as it is still in preview which would go against the criteria of the latest stable version of the program.

bucket/windows-terminal.json Outdated Show resolved Hide resolved
bucket/windows-terminal.json Outdated Show resolved Hide resolved
bucket/windows-terminal.json Show resolved Hide resolved
bucket/windows-terminal.json Outdated Show resolved Hide resolved
bucket/windows-terminal.json Outdated Show resolved Hide resolved
@Bassetts
Copy link
Contributor Author

All suggested changes have been made 👍

bucket/windows-terminal.json Outdated Show resolved Hide resolved
@Ash258 Ash258 merged commit bbed112 into ScoopInstaller:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Add Windows Terminal
5 participants