Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scoop update stuck on git log #2144

Closed
marknelissen opened this issue Mar 21, 2018 · 8 comments
Closed

scoop update stuck on git log #2144

marknelissen opened this issue Mar 21, 2018 · 8 comments
Labels
bug

Comments

@marknelissen
Copy link

@marknelissen marknelissen commented Mar 21, 2018

When running the scoop update command, it goes to the git log view.
image

When leaving this view, (press q), the console remains on doing nothing. The only way to leave this state and come back to the prompt is to kill the process.

Here is the git information I see you ask in these type of issues:
image

It also displays this behaviour when trying to update the installed components, both through * and specific package, preventing updating through scoop.
image

@h404bi

This comment has been minimized.

Copy link
Contributor

@h404bi h404bi commented Mar 21, 2018

Related: #2133
temporary workaround: revert commit: 56c35f8

@marknelissen

This comment has been minimized.

Copy link
Author

@marknelissen marknelissen commented Mar 21, 2018

Thank you for your quick response.

Is there a reason not to publish the revert of this commit on the central master branch? Does it only occur under specific circumstances?

@h404bi

This comment has been minimized.

Copy link
Contributor

@h404bi h404bi commented Mar 21, 2018

It only occur when you didn't update scoop for some time, when there is a long commit history.
We want a better solution to deal with update log, discussion at #2133 , instead of just reverting the commit.

@marknelissen

This comment has been minimized.

Copy link
Author

@marknelissen marknelissen commented Mar 21, 2018

So, after I update scoop, I can revert the revert?

@marknelissen

This comment has been minimized.

Copy link
Author

@marknelissen marknelissen commented Mar 21, 2018

However, as I understand it, without fundamentally changing the way the update log works, you would run into the same issue as here when enabling the verbose mode proposed by #2133 .

r15ch13 added a commit that referenced this issue Mar 21, 2018
r15ch13 added a commit that referenced this issue Mar 21, 2018
@r15ch13

This comment has been minimized.

Copy link
Collaborator

@r15ch13 r15ch13 commented Mar 21, 2018

git log pauses if there are too many lines. I disabled the pagination with cac9975
Updating should continue when you press and hold enter to show more log entries.
Or remove the "lastupdate" value from %USERPROFILE%/.scoop

@rasa rasa added the bug label Mar 21, 2018
@rasa

This comment has been minimized.

Copy link
Collaborator

@rasa rasa commented Mar 21, 2018

This was fixed in cac9975 , right?

@marknelissen

This comment has been minimized.

Copy link
Author

@marknelissen marknelissen commented Mar 21, 2018

I confirm, when leaving the history, the update completes now, even if you leave by pressing 'q' (no need to scroll to the ending by enter). Tested it by setting my last update date far into the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.