Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package still get installed after hash check failed #2245

Open
gengen1988 opened this issue May 5, 2018 · 1 comment
Open

Package still get installed after hash check failed #2245

gengen1988 opened this issue May 5, 2018 · 1 comment
Labels
bug

Comments

@gengen1988
Copy link

@gengen1988 gengen1988 commented May 5, 2018

image

I believe hash checking prevents the man-in-the-middle attack. A package failed in check may injected with malware and should not be install.

@r15ch13

This comment has been minimized.

Copy link
Collaborator

@r15ch13 r15ch13 commented May 6, 2018

It doesn't get installed. The error message shows up because scoop has already created an empty directory and the check if it's installed gets it wrong. This a bug.

@r15ch13 r15ch13 added the bug label May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.