New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds haxe-preview version and Hashlink #3048

Merged
merged 3 commits into from Feb 1, 2019

Conversation

Projects
None yet
3 participants
@mundusnine
Copy link
Contributor

mundusnine commented Jan 30, 2019

To use hashlink we need to have the preview version which is an in-development version of haxe. Hashlink is a VM that works with haxe.

mundusnine-win
Adds haxe-preview version and Hashlink
To use hashlink we need to have the preview version which is an in-development version of haxe. Hashlink is a VM that works with haxe and can also be used for native compilation of apps.
@Ash258

This comment has been minimized.

Copy link
Contributor

Ash258 commented Jan 30, 2019

Haxe

  • Use $version inside autoupdate instead of that $matchHead Tail combination
  • Use architecture for both 64bit and 32bit
  • Why to append $dir into path, when there is only single binary file?
  • No description

Ar

Hashlink

  • Again. Why append path?
  • No description
  • Use only version to version property. Not some text after it, which is not relate to that version
{
    "homepage": "https://hashlink.haxe.org/",
    "version": "1.8.0",
    "license": "MIT",
    "url": "https://github.com/HaxeFoundation/hashlink/releases/download/1.8/hl-1.8.0-win.zip",
    "hash": "f20b4f5619cdcd56616185cfd22c1294f44e0f3e76bed4c63ac47344b82cb9da",
    "extract_dir": "hl-1.8.0-win",
    "bin": "hl.exe",
    "env_set": {
        "HASHLINKPATH": "$dir"
    },
    "checkver": {
        "github": "https://github.com/HaxeFoundation/hashlink/",
        "regex": "([\\d\\.]+)-win"
    },
    "autoupdate": {
        "url": "https://github.com/HaxeFoundation/hashlink/releases/download/$majorVersion.$minorVersion/hl-$version-win.zip",
        "extract_dir": "hl-$version-win"
    }
}
@mundusnine

This comment has been minimized.

Copy link
Contributor Author

mundusnine commented Jan 30, 2019

@Ash258

  • Append to path question: For the path of haxe have a look at the haxe.json already in the main bucket which this manifest is based off of. For hashlink have a look at the documentation of heaps

  • All other comments will be fixed.

mundusnine-win added some commits Jan 30, 2019

mundusnine-win
mundusnine-win

@r15ch13 r15ch13 merged commit e661d3c into lukesampson:master Feb 1, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment