Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcd duplicate generators #401

Closed
lukew3 opened this issue Dec 22, 2022 · 0 comments
Closed

gcd duplicate generators #401

lukew3 opened this issue Dec 22, 2022 · 0 comments

Comments

@lukew3
Copy link
Owner

lukew3 commented Dec 22, 2022 •
edited
Loading

Bug Description

Generators with ids 10 and 120 are both gcd generators. One will have to be removed.
I think that misc.gcd is the better algorithm, but it would make sense to only access it in basic_math

misc.hcf is also the same
@lukew3 lukew3 changed the title 10 and 20 are duplicates 10 and 120 are duplicates Dec 22, 2022
@lukew3 lukew3 changed the title 10 and 120 are duplicates gcd duplicate generators Dec 26, 2022
lukew3 added a commit that referenced this issue Dec 27, 2022
@lukew3
remove gcd duplicates; for #401
d11be95
@lukew3 lukew3 closed this as completed Dec 27, 2022
lukew3 added a commit that referenced this issue Dec 27, 2022
@lukew3
No Generator class (#405)
a2d2a1b 
* Create ids list

* rm Genimprt, rm inst in algebra + basic_math

* computer science and calculus no inst

* Remove instances from geometry

* remove instances from misc

* remove instances from permutations

* fix under indentations

* improve binary_complement_1s

* Remove generator.py

* initial docs setup

* move modules out of funcs, regen docs

* Move subjects to single files

* pdoc docs

* add make docs

* Remove mid-file imports, delete templates

* lint fixes

* Use math in docs

* remove format string from complex_quad

* regen docs

* Lint fix

* Hide non-generator modules from docs

* Hide utility methods from docs

* Created _gen_list.py

* Remove docs from readme

* replace tabs with 4 spaces

* lint fixes

* little docs changes

* docstrings for half of subjects

* Added example docs for remaining generators

* update docs

* Update intersection of two lines #408

* Snake case variables; for #406

* update docs

* Remove escaped backslashes; for #407

* autopep8

* lint fix

* lint fix

* remove gcd duplicates; for  #401

* Add missing delimiter for fraction_multiplication

* rebuild docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukew3