Feat/getToken wrapper

[aureldent]

No description provided.

[codecov-io]

Codecov Report

Merging #74 into master will decrease coverage by 0.37%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   65.35%   64.98%   -0.38%     
==========================================
  Files          13       13              
  Lines         765      771       +6     
==========================================
+ Hits          500      501       +1     
- Misses        265      270       +5

Impacted Files	Coverage Δ
lumapps/api/client.py	28.32% <25%> (-0.31%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74fbf45...1c09484. Read the comment docs.

[ulodciv]

Why not add an argument to get_new_client instead? Perhaps called something like use_get_token?

[aureldent]

Because I wanted to have a function that does one and only one thing that is correctly authenticate as a new user.
Also I feeled that authenticate_on_behalf_of was clearer.
We can maybe use that method to extend get_new_client_as if that seems right to you.

[ulodciv]

I have nothing against creating a new method, but, doesn't get_new_client_as return also an ApiClient "on behalf of"?

[aureldent]

Never used it, but from what i understand not really that would use the account wide delegation (that use a little magic in the google library by calling the credentials with_subject method) so no quite what we want to do there :)