Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email type problem in lx-text-field #37

Closed
ekaitzht opened this issue Dec 11, 2014 · 4 comments
Closed

Email type problem in lx-text-field #37

ekaitzht opened this issue Dec 11, 2014 · 4 comments
Labels

Comments

@ekaitzht
Copy link

I have seen that when yout type the email in this lx-text-field (http://ui.lumapps.com/directives/text-fields)

        <lx-text-field label="Email" fixed-label="true" type="Email"></lx-text-field>

your email is overlapping the label/placeholder.

@malexandre malexandre added the bug label Dec 11, 2014
@malexandre
Copy link
Contributor

Thanks for reporting the issue. We saw it this morning. The HTML5 validation is stopping the model from being updated. We'll try to find a solution soon.

@tagazok
Copy link

tagazok commented Dec 11, 2014

I haven't test with email but I have the same problem with 'date' type in text-field.
In the other hand, the 'number' html5 type works.

@malexandre
Copy link
Contributor

It's kind of a problem from Angular. They decided that the model must not be updated if the value doesn't validate the HTML5 type. And our directive watch the model to now if there is a need to slide up the label. I'll try to manage this by a "change" jqlite event instead of a watch on the model, but I'm not sure it's the best solution.

@malexandre
Copy link
Contributor

The solution is available in the last release. By using a mix between the watch of the ng-model and the watch of changes with jqlite, it's now working event for the HTML5 type that didn't work before.
But please see the changelogs as there are breaking changes with the text-fields directive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants