Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start making SPI configurable #807

Merged
merged 20 commits into from
Mar 26, 2023
Merged

Conversation

markusdd
Copy link
Contributor

This is work in progress to make SPI pins configurable as the old hardcoded approach breaks down as described in #806

@markusdd
Copy link
Contributor Author

This PR basically ready for review by you @lumapu .

It switches to the cutsom SPIClass constructor while keeping backward compatibility, which should be tested by people who own a classic ESP32 and ESP8266.
For ESP82 the web interface disables the new SPI pin selection as it is impossible on that chip.

Also, the available pinlist for esp32s3 has been added, as it has more pins and more flexibility even compared to the ESP32.
(otherwise e.g. pins 47/48 are inaccessible for config)

grafik
grafik

@lumapu
Copy link
Owner

lumapu commented Mar 26, 2023

looks really good to me, thank you for your contribution!
I will check the code on a ESP8266 before I will merge this PR into the next dev-build

@markusdd
Copy link
Contributor Author

I should note that it is probably necessary to do a complete config erase for this build as it alters the configuration structure, I at least noticed some weird config display (actually it is logical as we expanded the pinout section, so the old config layout won't match)

lumapu added a commit that referenced this pull request Mar 26, 2023
* merge: PR SPI pins configureable (ESP32) #807
@lumapu lumapu merged commit 8f2cac7 into lumapu:development03 Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants