Alan Cohen lumberj

lumberj closed pull request ripple/ripple-rest#365
@lumberj
Add eslint task to package.json
lumberj commented on pull request ripple/ripple-rest#368
@lumberj

LGTM

lumberj commented on pull request ripple/ripple-rest#368
@lumberj

It would be helpful if the commit message included which dependencies you updated, since the shrinkwrap will have all the child dependency updates …

lumberj commented on pull request ripple/ripple-rest#368
@lumberj

How can you leave off ./node_modules/.bin without having these packages installed globally?

@lumberj
@lumberj
@lumberj
Do not send null in the callback
1 commit with 3 additions and 10 deletions
@lumberj
  • @lumberj 30810fb
    Add eslint task to package.json
lumberj opened pull request ripple/ripple-rest#365
@lumberj
Add eslint task to package.json
1 commit with 2 additions and 1 deletion
lumberj starred tj/n
lumberj commented on pull request ripple/ripple-rest#364
@lumberj

LGTM

lumberj commented on pull request ripple/ripple-rest#364
@lumberj

This looks good to me, but I would appreciate if the commit message mentions updating a dependency and adding a new one (https://github.com/lydell/…

@lumberj
@lumberj
@lumberj
@lumberj
lumberj deleted branch fix/broken-tests at lumberj/ripple-rest-client
@lumberj
@lumberj
Fix several tests that are not valid (and are currently breaking)
1 commit with 2 additions and 23 deletions
@lumberj
Fix several tests that are not valid (and are currently breaking)
1 commit with 2 additions and 23 deletions
lumberj deleted branch feature/get-notifications at lumberj/ripple-rest-client
@lumberj