New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release version parity #4

Closed
bdolor opened this Issue Sep 19, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@bdolor
Contributor

bdolor commented Sep 19, 2017

The version number of composer.json

based on the version number of the plugin

should match the release version on github

Otherwise composer can't find the release:

image

and small, fluffy white kittens cry. 😹

@monkecheese

This comment has been minimized.

Show comment
Hide comment
@monkecheese

monkecheese Sep 19, 2017

Collaborator

Haha! Sorry about the fluffy white kitten. First time managing releases. Thanks for the heads up!

Collaborator

monkecheese commented Sep 19, 2017

Haha! Sorry about the fluffy white kitten. First time managing releases. Thanks for the heads up!

@monkecheese

This comment has been minimized.

Show comment
Hide comment
@monkecheese

monkecheese Sep 19, 2017

Collaborator

Looks like it's working for me now. Here's what my composer.json looks like for my test case:

{
        "repositories": [
                {
                        "type": "vcs",
                        "url": "https://github.com/lumenlearning/candela-citation"
                }
        ],
        "require": {
                "lumenlearning/candela-citation": "1.0.0"
        }
}

Can you confirm it's working for you @bdolor?

Collaborator

monkecheese commented Sep 19, 2017

Looks like it's working for me now. Here's what my composer.json looks like for my test case:

{
        "repositories": [
                {
                        "type": "vcs",
                        "url": "https://github.com/lumenlearning/candela-citation"
                }
        ],
        "require": {
                "lumenlearning/candela-citation": "1.0.0"
        }
}

Can you confirm it's working for you @bdolor?

@monkecheese monkecheese added the bug label Sep 19, 2017

@bdolor

This comment has been minimized.

Show comment
Hide comment
@bdolor

bdolor Sep 19, 2017

Contributor

yay
image

Contributor

bdolor commented Sep 19, 2017

yay
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment