From 69d253fdcfadd0334b1cff6341e9e6def0bc87f1 Mon Sep 17 00:00:00 2001 From: nirLumigo Date: Thu, 28 Jan 2021 16:47:39 +0200 Subject: [PATCH] Fix domains-scrubber --- src/lumigo_tracer/lumigo_utils.py | 6 ++++-- src/test/unit/test_lumigo_utils.py | 6 ++++++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/lumigo_tracer/lumigo_utils.py b/src/lumigo_tracer/lumigo_utils.py index 43409ec4..33903f78 100644 --- a/src/lumigo_tracer/lumigo_utils.py +++ b/src/lumigo_tracer/lumigo_utils.py @@ -16,6 +16,8 @@ import inspect import traceback +LUMIGO_DOMAINS_SCRUBBER_KEY = "LUMIGO_DOMAINS_SCRUBBER" + try: import botocore import boto3 @@ -182,9 +184,9 @@ def config( Configuration.send_only_if_error = os.environ.get("SEND_ONLY_IF_ERROR", "").lower() == "true" if domains_scrubber: domains_scrubber_regex = domains_scrubber - elif "LUMIGO_DOMAINS_SCRUBBER" in os.environ: + elif LUMIGO_DOMAINS_SCRUBBER_KEY in os.environ: try: - domains_scrubber_regex = json.loads(os.environ["LUMIGO_DOMAIN_SCRUBBER"]) + domains_scrubber_regex = json.loads(os.environ[LUMIGO_DOMAINS_SCRUBBER_KEY]) except Exception: get_logger().critical( "Could not parse the specified domains scrubber, shutting down the reporter." diff --git a/src/test/unit/test_lumigo_utils.py b/src/test/unit/test_lumigo_utils.py index 99d6a3a8..e46839ba 100644 --- a/src/test/unit/test_lumigo_utils.py +++ b/src/test/unit/test_lumigo_utils.py @@ -390,6 +390,12 @@ def test_config_enhanced_printstep_function_without_envs(monkeypatch, configurat assert Configuration.is_step_function == configuration_value +def test_config_lumigo_domains_scrubber_with_envs(monkeypatch): + monkeypatch.setenv("LUMIGO_DOMAINS_SCRUBBER", '["lambda.us-west-2.amazonaws.com"]') + config() + assert len(Configuration.domains_scrubber) == 1 + + def test_config_timeout_timer_buffer_with_exception(monkeypatch): monkeypatch.setenv("LUMIGO_TIMEOUT_BUFFER", "not float") config()