Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websockets page does not contain an example for the new default server Jetty #245

Closed
sorsasampo opened this issue Aug 5, 2019 · 3 comments

Comments

@sorsasampo
Copy link

commented Aug 5, 2019

The Websockets page contains websocket examples for Immutant and HTTP KIT, but not for the new default server Jetty (since luminus-template 3.37).

http://www.luminusweb.net/docs/websockets.html

@yogthos

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

The official Jetty adapter doesn't appear to provide Websocket support, I'd recommend using HTTP Kit if you need Websockets. It might make sense to switch Luminus to use it as the default.

@sorsasampo

This comment has been minimized.

Copy link
Author

commented Aug 8, 2019

I think websocket support is kind of important nowadays, so I would personally find it sensible to default to a server that supports them. I'm closing this issue as there is no way to provide an example for an implementation that does not exist!

@sorsasampo sorsasampo closed this Aug 8, 2019

@yogthos

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

I agree that ws support is important, and I'll investigate what might be the best option going forward. I'm leaning towards Aleph as the default, but it has a couple of issues that I'd like to see addressed first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.