Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to parse data in memory #8

Merged
merged 4 commits into from Jun 19, 2017
Merged

Add ability to parse data in memory #8

merged 4 commits into from Jun 19, 2017

Conversation

camertron
Copy link
Contributor

Currently, paxmex only supports loading files. I want to be able to parse strings in memory.

A couple of other things:

  1. Upgrade to RSpec 3
  2. Test against ruby 2.4
  3. Better public interface, eg. Paxmex.cbnot.parse(...) instead of Paxmex.parse_cbnot(...)

@lumoslabs/platform

@camertron camertron requested review from zvkemp and PolRod June 15, 2017 21:48
jdoconnor
jdoconnor approved these changes Jun 19, 2017
View reviewed changes
Copy link

@jdoconnor jdoconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camertron camertron merged commit 31ae4b4 into master Jun 19, 2017
@camertron camertron deleted the parse_and_load_file branch June 19, 2017 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdoconnor jdoconnor jdoconnor approved these changes

@zvkemp zvkemp Awaiting requested review from zvkemp

@PolRod PolRod Awaiting requested review from PolRod

Assignees

@jdoconnor jdoconnor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@camertron @jdoconnor