Fix incorrect query and args handling

[luna-duclos]

Closes #10

[aaslamin]

Still plumbing this in my project to test, but looking at the changes I don't think this is what you want to do?

We still want to create the arg tag in our spans if the OmitArgs is set to false. Logging is a separate thing all together. In order to this, we must conditionally call span.SetLabel("args", formatArgs(args)). Maybe I am missing something obvious? 😅

[aaslamin]

Update: I was able to build my project against your branch after battling it out a bit more about modules.

I can confirm this is not the behaviour we want as the tag is removed even if WithOmitArgs() is not set. Instead we want to conditionally remove the tag like it was being done in some places before. Also the query tag is removed all together:

[aaslamin]

So...this was previously good! We don't want to remove this check as far as I understand. Instead we want to do this in other places which are adding the args tag such as ExecContext and QueryContext.

[luna-duclos]

That's odd ... the call to logQuery a bit later is supposed to take care of that, I'll look into why that is broken

[luna-duclos]

Issues fixed, fix corrected, merging this :)

[aaslamin]

😍 Yay, thanks Luna! 🏆