Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

webkit: make it work again #21

Merged
merged 3 commits into from Aug 5, 2012

Conversation

Projects
None yet
2 participants
Member

elangelo commented Aug 1, 2012

bison
multithreaded stuff

@elangelo elangelo webkit: make it work again
bison
multithreaded stuff
713ca85

@v4hn v4hn closed this Aug 1, 2012

@v4hn v4hn reopened this Aug 1, 2012

Member

v4hn commented Aug 1, 2012

First of all I'm sorry to criticize your work again...
It's really great that webkit can be build in parallel again!
This reduces the compile time over here from 7 to 3 hours (using two Intel Atom processors and distcc),
so i agree with you that the result justifies the means in this case.
Nevertheless there are a couple of things wrong with this commit:
(1.) it introduces some whitespace errors(space at end of line and tab instead of spaces)
(2.) --enable-video is in DEPENDS already, any reason to require this dependency on gst-plugins-good?
(3.) The link you provide doesn't give any further link or statement by the webkit maintainers.
Please provide a link to a discussion of the PSAFE problems that makes it clear, that this is a good fix.

Member

v4hn commented Aug 1, 2012

Also you still didn't answer the question if you are sure the racing conditions
exist only with gobject-introspection enabled!
I got two errors when compiling this in parallel:
one related to some gir file and one related to linking.
This last one doesn't seem to have anything to do with gobject-introspection!
Also the hack works fine with $MAKES=1, so you can probably just remove
this whole if-then-else block and replace it by that until..

@v4hn v4hn added a commit that referenced this pull request Aug 5, 2012

@v4hn v4hn Merge pull request #21 from elangelo/webkit
webkit: 1.8.2 & bison 2.6 patch & "support" parallel build
1497f7e

@v4hn v4hn merged commit 1497f7e into lunar-linux:master Aug 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment