New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests on Lua 5.4.3 #379

Merged

Tieske merged 1 commit into lunarmodules:master from catwell:pr-fix-5.4.3-tests

Apr 30, 2021

Member

catwell commented Apr 29, 2021

see http://lua-users.org/lists/lua-l/2021-04/msg00024.html


          fix tests on Lua 5.4.3

002ad81

see http://lua-users.org/lists/lua-l/2021-04/msg00024.html

Member

Tieske commented Apr 30, 2021

should we be updating this since the error message will be changed back? or maybe cater for the 5.4.3 version as a special case?

Member Author

catwell commented Apr 30, 2021

Yes, we could detect 5.4.3 with Roberto's trick (http://lua-users.org/lists/lua-l/2021-04/msg00039.html).

I don't think it's much of a problem to just look for "a nil value" in all cases in this test though.

Tieske approved these changes

View changes

Tieske merged commit 10dfaea into lunarmodules:master

4 checks passed

Tieske mentioned this pull request

Tests failing in 5.4 due to error message issue #380

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment