Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make pcall loop dependent #173

Merged
merged 2 commits into from Jun 10, 2013
Merged

Conversation

lipp
Copy link
Contributor

@lipp lipp commented Jun 5, 2013

fixes #171

@lipp lipp mentioned this pull request Jun 5, 2013
This applies to luajit and Lua 5.1
@lipp
Copy link
Contributor Author

lipp commented Jun 10, 2013

@ajacksified Any comments / objections? I'd like to have this in master to continue working with HEAD revs. Most of my "real" tests crash without this fix. #171 has to be investigated further, but this is not trivial and will take some time.

@Tieske
Copy link
Member

Tieske commented Jun 10, 2013

maybe better to remove pcall from the loop interface. So everywhere just revert to using plain pcall and xpcall. And only in the busted.loop.copas file, upon requiring, replace the global pcall and coxpcall.

If it stays in the interface then I would prefer it to provide general methods loop.initialize() and loop.terminate(), which would then for the copas one do the global pcall substitution en reverting it.

@ajacksified
Copy link
Contributor

I don't like the idea of replacing globals - let's merge this for now to get things moving, since it doesn't effect the external interface, and continue to look for a better solution.

ajacksified added a commit that referenced this pull request Jun 10, 2013
@ajacksified ajacksified merged commit 3ef8951 into lunarmodules:master Jun 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation Fault
4 participants