Makefile is not very friendly to RPM spec file builds in Fedora and the like

[treveradams]

I am not sure what is going on, but if CFLAGS is defined in a SPEC file make command, the CFLAGS in the makefile are completely ignored, causing a failure to build.

If possible, these should just be prefixed to the CFLAGS in the Makefile.

[diegonehab]

What does passing the CFLAGS in the SPEC file do? Does it define the additional variable in the invocation of make? If so, this is the standard behavior: the variables defined in the makefile will be ignored. How do you do with Lua? Do you use MYCFLAGS etc?

[diegonehab]

I added MYCFLAGS and MYLDFLAGS. Please let me know if these are enough.

[treveradams]

I am just learning Lua. I imagine they will be enough. However, as I was just needing some functionality that was not yet in Fedora, I have asked those who actually do the official packaging to look here and follow up. If you would like to follow up with them, https://bugzilla.redhat.com/show_bug.cgi?id=985573 is the URL for the Fedora bug (this report is one of two patches in that report).

Thank you for the help!

[ewestbrook]

Does anything further need to be done here?

We're reviewing open items in preparation for a release. If action is needed here, please add a comment. Otherwise, this issue will be closed on or after 24-Feb-2019.

Thanks!