Include port in default Host header #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See RFC 2616 section 14.23.
|
Ping? I really think you could merge this. |
|
Away on annual leave. Will merge next week! :) Sent from my phone On Aug 30, 2013, at 16:04, Pierre Chapuis notifications@github.com wrote:
|
|
OK no problem :) Enjoy your time off. |
diegonehab
added a commit
that referenced
this pull request
Sep 9, 2013
Include port in default Host header
This was referenced Jul 15, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
See RFC 2616 section 14.23: if the port is not the default it should be included in the Host header.
Currently it is not and it actually results in
404errors with strict HTTP servers like the Flask stack with SERVER_NAME set.This pull request fixes this by appending the port if needed.