Skip to content

Conversation

@lungben
Copy link
Owner

@lungben lungben commented Sep 30, 2020

Putting all packages for importing different file formats as direct dependencies is quite convenient for the user, but has serious drawbacks:

  1. The time for importing TableIO is very long (ca. 30s)
  2. The installation of TableIO is very heavy-weight and includes many packages the user probably does not need
  3. There may be issues due to incompatible dependences

Here, I am making all dependencies except CSV.jl and DataFrames.jl optional using Revise.jl. This makes the installation more light-weight and importing much faster (4s after precompilation for me).

ToDo: document how to use the optional dependencies

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020

Codecov Report

Merging #9 into master will increase coverage by 4.59%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master        #9      +/-   ##
===========================================
+ Coverage   95.40%   100.00%   +4.59%     
===========================================
  Files           3         8       +5     
  Lines          87        89       +2     
===========================================
+ Hits           83        89       +6     
+ Misses          4         0       -4     
Impacted Files Coverage Δ
src/TableIO.jl 100.00% <100.00%> (ø)
src/jdf.jl 100.00% <100.00%> (ø)
src/parquet.jl 100.00% <100.00%> (ø)
src/postgresql.jl 100.00% <100.00%> (ø)
src/sqlite.jl 100.00% <100.00%> (ø)
src/stat_files.jl 100.00% <100.00%> (ø)
src/xlsx.jl 100.00% <100.00%> (ø)
src/zipped_csv.jl 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dc606...5c03da3. Read the comment docs.

@lungben lungben merged commit 86c68cd into master Oct 1, 2020
@lungben lungben deleted the requires branch October 2, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants