Fixes #18 & #19 - no env data 'cause of bail & alt path #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvm crashes out with a warning if `$GEM_HOME/bin` isn't the first $PATH value which then doesn't allow any environment variables to be created for this script to utilize. RVM will work here by simply placing the value it expects in the beginning of the PATH environment variable for the temporary environment that this is grabbing data from. Fixes #19
RVM isn't always installed in the home directory. This update uses RVM's `scripts/rvm` where-ever it is. Fixes #18
danielpclark
changed the title
|
Verified
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rvmcrashes out with a warning if$GEM_HOME/binisn't the first$PATHvalue which then doesn't allow any environment variables to be created for this script to utilize. RVM will work here by simply placing the value it expects in the beginning of thePATHenvironment variable for the temporary environment that this is grabbing data from.c2cc5ab Fixes #19
RVM isn't always installed in the home directory. This update uses RVM's
scripts/rvmwhere-ever it is.0a2bdfa Fixes #18