Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new theme 'so-clean', mock `currentUserID` with `req.query.currentUser` #3

Merged
merged 6 commits into from Nov 22, 2017

Conversation

@moesoha
Copy link
Member

moesoha commented Nov 17, 2017

The design of theme so-clean comes from Hashable/so-clean.

Copy link
Contributor

laosb left a comment

Some style point-outs.

And, did you get any permission to adapt this theme from the original author? Please include a copy of permission in your theme as a plain text file (or maybe .md).

EDIT: Found the original source is licensed in MIT, so you only need to include the original LICENSE file in your theme.

@@ -0,0 +1,13 @@
<template>
<nav class="pagination" role="navigation">
<a class="newer-posts" @click="callback(page - 1)" v-if="page>1"><span aria-hidden="true">&larr;</span> 新点儿的</a>

This comment has been minimized.

Copy link
@laosb

laosb Nov 17, 2017

Contributor

Better lint code in vue expressions too, by yourself. Add spaces before and after operators.


iframe {
max-width: 100%;
}

This comment has been minimized.

Copy link
@laosb

laosb Nov 17, 2017

Contributor

Always put a new line at the end of a source code file.

moesoha added 2 commits Nov 19, 2017
Add LICENSE of the original theme
@moesoha

This comment has been minimized.

Copy link
Member Author

moesoha commented Nov 19, 2017

Changes committed. @laosb

@laosb
laosb approved these changes Nov 22, 2017
@laosb

This comment has been minimized.

Copy link
Contributor

laosb commented Nov 22, 2017

LGTM

@laosb laosb merged commit 5f8700f into luogu-dev:master Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.