[pull] master from chromium:master #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Roll Chrome Win64 PGO profile from chrome-win64-main-1633337654-919aed836eea2811c24418c8c7d6d322f1e7d71b.profdata to chrome-win64-main-1633348314-3620055a3541c755372f059073568761b48503ab.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I38f0e16f707743c3a13e80be737255ceb15f83cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202292 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927666}
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/51ba9ba9e970..3303d7f44c6a 2021-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com Change-Id: I3570ec63267bae530ee22164a2506024605e5c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202293 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927667}
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/311764fabbd9..227445f613e2 2021-10-04 apodtele@gmail.com [pshinter] More convenient direction definition. 2021-10-04 apodtele@gmail.com [pshinter] Remove unnecessary check. 2021-10-02 anuthadev@gmail.com CI: Hardcode meson version to fix build failure on windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10.20h2-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I3bcc304eafec2e2cea9d173efc2b84be303784f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200662 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/main@{#927668}
Roll Chrome Win32 PGO profile from chrome-win32-main-1633337654-05febac5d286d079ebfab11663a8069042365a6e.profdata to chrome-win32-main-1633348314-400d787a1fa34955af42baf1365b3a736b02e83f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I89402e98a428a9630cfcd717185d26901e66d49b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200741 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927669}
According to feedback from UXR research and UX team, the bubble visibility was too short and should be prolongated to 6 seconds. The toast should still be visible for 2.5 seconds. See https://docs.google.com/document/d/1vecpxQjuir1jX7r6kvs2vhPu0RuCp17_TUeA7bPzxUA/edit?disco=AAAAPVQPqzE Bug: 1096461 Change-Id: I6b7390a74953cbde280a65ce605302c3770353a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198886 Reviewed-by: Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/main@{#927670}
This patch makes Element::RecalcOwnStyle take HighlightInheritance- based highlight styles into account when comparing old and new styles, which in turn allows us to invalidate highlight painting (CL:3177663) correctly by calling LayoutObject::SetStyle in the right conditions. We first reorder the new highlight recalcs so they happen before the ComputeDifference call. Under the old behaviour, diffs always saw a null HighlightData in the new style, so when changing highlight styles only, we got kInherited iff the old HighlightData was non-null, or kEqual otherwise. Then we make PseudoElementStylesEqual skip over the highlight pseudos when HighlightInheritance is enabled. Under the old behaviour, we were assuming that GetCachedPseudoElementStyle would return a meaningful result for highlight pseudos, erroneously returning false, clamping the diff up to kPseudoElementStyle. Finally we change the behaviour of StyleHighlightData::operator== from reference equality to DataEquivalent (reference-and-value equality). Without this, changes in the cascade that don’t actually change values would result in spurious kInherited diffs. Net result of these changes: • https://bucket.daz.cat/work/igalia/1/4.html (requires CL:3177663), ::target-text magenta-to-lime, continues to pass, but now it passes for the right reason, not just because old HighlightData is non-null and new HighlightData is null • https://bucket.daz.cat/work/igalia/1/5.html (requires CL:3177663), ::target-text nothing-to-lime, newly passes, because we no longer compare an old HighlightData of null to a new HighlightData of null • https://bucket.daz.cat/work/igalia/1/6.html (requires CL:3177663), ::target-text lime-to-lime, eliminates the spurious fragment paint • https://bucket.daz.cat/work/igalia/1/7.html (no other CL required) ::selection magenta-to-lime, continues to pass, because ::selection is unaffected by this bug (see ApplyPseudoElementStyleChanges) • https://bucket.daz.cat/work/igalia/1/8.html (no other CL required) ::selection nothing-to-lime, continues to pass, because ::selection is unaffected by this bug (see ApplyPseudoElementStyleChanges) • https://bucket.daz.cat/work/igalia/1/9.html (no other CL required) ::selection lime-to-lime, eliminates the spurious fragment paint Bug: 1024156, 1251193 Change-Id: I19210393ec91fb08593a1d97757732847acf4b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197850 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Delan Azabani <dazabani@igalia.com> Cr-Commit-Position: refs/heads/main@{#927671}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f9a6331c5a0f..e2c9f764dd89 2021-10-04 tvanderlippe@chromium.org Add migration script for private class fields 2021-10-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-10-04 nancyly@chromium.org [DevTools Quick Open] Fix the UI bug when the dislog is super narrow 2021-10-04 jegarc@microsoft.com Add tabindex to XLink If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1222126,chromium:1255167 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia9f8b0f918161d28e832097b90593b4ca0b6e9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202290 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927672}
https://android.googlesource.com/platform/external/perfetto.git/+log/7ebf8a2e875f..588a25f21493 2021-10-04 octaviant@google.com ui: Cherry-pick unsafe-eval for Wasm If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:201596551 Tbr: perfetto-bugs@google.com Change-Id: I59d326bcc52df7f0e1b77bd485139dc59d1c1b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201749 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927673}
Roll Chrome Linux PGO profile from chrome-linux-main-1633326658-6fb420062593bb5549d950d3c8eaba216e7d8abd.profdata to chrome-linux-main-1633348314-d02af1c661bbb2a462867842b18040e6aa068fb4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3987321ff353a2473fd8defb668d0247a6a89a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201811 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927674}
Bug: 1227656 Change-Id: I6ddba4e609c69487c42688c1094b2a08942deda1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195910 Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/main@{#927675}
This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDD> Bug: 1164001 Change-Id: I7a3aa7ec1225800bc65762eee38eab237593d0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3196171 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Owners-Override: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/main@{#927676}
Bug: 606485 Change-Id: I0a6f237966e1caaccd7bc83992b2b9cf4b38c8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201633 Owners-Override: Leonard Grey <lgrey@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/main@{#927677}
Change-Id: I4b10dfaea3e95149a19e32e37027eb5aa5ef714d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202112 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927678}
PasswordStoreInterface is an interface that should be used by other classes instead of interacting directly with PasswordStore. Bug: 1218413 Change-Id: I620c781831695c18e91c559bd0ad470737b70926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198175 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/main@{#927679}
Add event listeners and increase the delay to observe all entries. This is a reland of 1ec60fb Original change's description: > Add a wpt for interaction id. > > This CL is for adding a wpt to check if we assign correct interaction > ids when we click. > > Bug: 1236758 > Change-Id: I0c6fad3ef9301fc54868f4aee01507e7142d14e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197873 > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/main@{#927211} Bug: 1236758 Change-Id: I96cb1773af42db9816a55c36b8a4f77243c02d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198749 Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/main@{#927680}
PasswordStoreInterface is an interface that should be used by other classes instead of interacting directly with PasswordStore. Bug: 1218413 Change-Id: I360885468d978739405dc9a9446514f29b6c302c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198174 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/main@{#927681}
Bug: 1254332 Change-Id: I3bd1f511aa5db752420dd9f1769cc741b8801d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197835 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/main@{#927682}
This fixes a crash in FD watching of PerfettoTaskRunner. When a FD is added, removed and then added for watching, the pending tasks posted in the add operations can cause repeated watching of the same FD to cause a crash when the 2nd remove operation fails. Fix the crash by canceling the pending task in the add operation to make sure there is only one valid pending task to watch the FD. Bug: 996777 Test: base_unittests: PerfettoTaskRunnerTest.FileDescriptorReuse Change-Id: I7b52a3f82e9139dc0806709bd361fd6f5a5868a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198065 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/main@{#927683}
R=aerotwist@chromium.org Bug: 1222126 Change-Id: Ic4ff8e728863a05068f7bb5deee1a8aa8770946f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201682 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/main@{#927684}
PasswordStoreInterface is an interface that should be used by other classes instead of interacting directly with PasswordStore. This class is already refactored, this CL does a cleanup of the remaining PasswordStore usages. Bug: 1218413 Change-Id: I4957a5c9d18a156ccbfac73ecffe0ee31ac3dc27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199780 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/main@{#927685}
The temporary solution with syslogging block/report events should be removed as not used anymore as full realtime reporting is ready. Bug: 1166600 Change-Id: Ide4fef03bc549a1ffae07fffdf683394591f6671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198887 Commit-Queue: Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Auto-Submit: Sergey Poromov <poromov@chromium.org> Reviewed-by: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/main@{#927686}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f10c20f9371a..bb35203345fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lgrey@google.com,engedy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: lgrey@google.com,engedy@google.com Change-Id: I534bd9fb11bf51c60e09148c0bb1048afaecafa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202295 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#927687}
PartitionAlloc. This script takes a trace from about:tracing, and a list of bucket sizes, and computes how much extra space would be used if the allocations in the trace were done with the given bucket sizes. This gives us a rough estimate of how much extra memory a given bucket mapping would use, computed statically based on surviving allocations only. Bug: 1238858 Change-Id: Iaa9b24b1d7669f3b12c71396911b47990ae402e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3188991 Reviewed-by: Egor Pasko <pasko@chromium.org> Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/main@{#927688}
…th -Wno-unreachable-code-break" This reverts commit 41be5f7. Reason for revert: No longer necessary now that 5be706d has landed. Original change's description: > Temporarily build breakpad's minidump-2-core and symupload with -Wno-unreachable-code-break > > The warning is fixed upstream, but rolling breakpad is currently paused. > This allows us to decouple -Wunreachable-code-aggressive from breakpad updates. > > Bug: 1066980,1238693 > Change-Id: I19ac187c720ecca18c9d66be9c5792d1d0004cc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3103686 > Commit-Queue: Nico Weber <thakis@chromium.org> > Commit-Queue: Mark Mentovai <mark@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#912996} Bug: 1066980,1238693 Change-Id: I09c4a428c272c545279f67a0d38668c4ed136204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3104885 Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#927689}
https://android.googlesource.com/platform/external/perfetto.git/+log/23b1b0ba5f62..7ebf8a2e875f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic46ec6c1e653cee5b2fad6a1effdfd777f368fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201919 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927690}
Bug: 1253409 Change-Id: Icca927be6ffd5883a422f6c69a608243530da4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200353 Reviewed-by: Gayane Petrosyan <gayane@google.com> Reviewed-by: sebsg <sebsg@chromium.org> Auto-Submit: Gayane Petrosyan <gayane@google.com> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/main@{#927691}
Bug: 1247452 Change-Id: I78867a70521e1ca833cdd1e1185b410183560bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202116 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/main@{#927692}
Correct the description for deprecated enum in UnderlayDamageRect. "Occluding Damage Only" is the one that is deprecated. See the code in overlay_processor_interface.cc where kOccludingDamageOnly is no longer used. https://source.chromium.org/chromium/chromium/src/+/main:components/viz/service/display/overlay_processor_interface.cc;l=41 Change-Id: Ie208c40496c95a952f7708d6749c1d565c58c652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200593 Auto-Submit: Maggie Chen <magchen@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/main@{#927693}
This reverts commit 628878c. Reason for revert: Potential breakage, reported in 1255546. Bug: 1230567, 1255546 Original change's description: > [Trusted Types] Ensure execCommand('insertHTML') is TT-safe. > > Trusted Types protects against XSS by providing a configurable boundary > for HTML insertion into the DOM. execCommand with the "insertHTML" command > works around these. This introduces Trusted Types check for > execCommand("insertHTML") that are the exact equivalent of element.innerHTML. > > Tests ensure that - if TT is not enabled - execCommand will work as before. > Tests also ensure that - if TT is enabled - execCommand with "insertHTML" > will obey TT policies and the default policy, while other sub-commands will > continue to work as before. > > Bug: 1230567 > Change-Id: Iaa50b01bec4061f53b6d66b0b21f63527f2b71a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3048161 > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> > Cr-Commit-Position: refs/heads/main@{#927214} Bug: 1230567 Change-Id: I7fc1eba34917f71a0883c8d39c4853c04f6a385c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201975 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/main@{#927694}
This reverts commit d7f1a73. With the recent guest kernel (virtio-fs) fix at https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3195366 the memory experiment is unnecessary to run Roblox's Royale High on 4GB devices. See b/201610520 for more information. BUG=b:191420639,b:199100833,b:201610520 TEST=try Change-Id: Ib1442634c5c0884923f3c3480a88607b97c249be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200400 Reviewed-by: Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/main@{#927695}
- Fixes typo in data-point style declaration. - Applies correct style to drawer title. Screenshot: https://screenshot.googleplex.com/7rvRRSjUQtwVWWL.png UX Spec (figma access required): http://shortn/_u7uQ8CmIPS Bug: 1197335 Change-Id: I7ab3736c93d3286a3146532fddd62c53071e4fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199060 Auto-Submit: Ashley Prasad <ashleydp@google.com> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/main@{#927776}
https://swiftshader.googlesource.com/SwiftShader.git/+log/f43b9df4c8a9..337c513cb645 2021-10-04 nicolascapens@google.com Kokoro: Disable gcp_ubuntu builds failing to update CMake If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-eng+autoroll@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-eng+autoroll@google.com Change-Id: Id17adf53428bd254d64857ba34ba2d48a502302a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202691 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927777}
Screenshot: https://screenshot.googleplex.com/8nDa5vu93cYufAJ.png UX Spec (figma access required): http://shortn/_u7uQ8CmIPS Bug: 1197335 Change-Id: Ic09b4a1c89f1145788c496ce3ea3c2d1be9c67c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200534 Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/main@{#927778}
This is the beginning of an interactive keyboard diagram to be used for internal keyboards. In future it will show the appropriate keys and labels for the device's physical keyboard and toggle their pressed state when the user presses keys, but this CL lays out the basic grid-based diagram. Screenshot: http://shortn/_b5piuj30fb (The "backspace" text overflowing is a known issue — not worth fixing until the dialogue and diagram sizing is worked out later on.) Bug: 1207678 Change-Id: Iea1a1594bacf803704be0e82b1520476b7abec1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193505 Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/main@{#927779}
linux-lacros-dbg-tests-fyi build fails because it miss the filter for all other test suites, it should have similar unit test filter as other linux-lacros builder Bug: 1233247 Change-Id: Ic2c4c26442a056811a79f06ebb652229250c0f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201032 Reviewed-by: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by: Sven Zheng <svenzheng@chromium.org> Commit-Queue: Jieting Yang <yjt@google.com> Cr-Commit-Position: refs/heads/main@{#927780}
We don't want to enable it by default in M96 beta/stable. BUG=b:186278424 TEST=try Change-Id: Ibe74369d36e681e648183c345bb3d98fdb3ecec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3176187 Reviewed-by: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Brian Geffon <bgeffon@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/main@{#927781}
Bug: 1252453 Change-Id: Icfb594efca7b9018f89035f0211aa864d219a138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180201 Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Mei Liang <meiliang@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/main@{#927782}
https://android.googlesource.com/platform/external/perfetto.git/+log/bf487cf7d6c8..6a46cc75169a 2021-10-04 primiano@google.com CHANGELOG in preparation for v20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icf7d051a9e1102a17710fe266d1a3ace63ddeea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202456 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927783}
This is intended as a cleanup, but also affect the referenced bug since this changes the expression used to compute the resulting angle. (Before this change it was hue * N / D while after it will be hue * (N / D), where N / D is a constant expression.) Bug: 1255121 Change-Id: I9f56a43158eb7358f4d080985758c3471748c72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198889 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/main@{#927784}
This adds a latency metric for the on-device page entity model. Bug: 1243049 Change-Id: Ie3d65688940418d105ba76e90636838d3243f11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199096 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/main@{#927785}
The Exit item in the hamburger menu makes no sense on Lacros as Lacros should get closed window by window and not like an app everything at once. BUG=1243654 Change-Id: I07aebdf0a8ed00ec4d800d844c3eb7fbcd022f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200395 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Stefan Kuhne <skuhne@chromium.org> Auto-Submit: Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/main@{#927786}
The policy is only launching in M96, so make the policy definition reflect that. Bug: 1224886 Change-Id: Ia7731594bb89996df8c033ab1cd9d708d1f77b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202493 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/main@{#927787}
Two JS files, enterprise_platform_keys/internal_api.js and platform_keys/internal_api.js, just exposed methods that were on the internal platform keys APIs. These, though, are already accessible to other custom bindings if they use getInternalApi directly. Update the consumers to do this, and remove the internal_api.js files. Bug: 1096029 Change-Id: I7c7f5ca5bf53629a811caf41f93af2ae5d1b9aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200178 Reviewed-by: Tim Judkins <tjudkins@chromium.org> Reviewed-by: John Lee <johntlee@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/main@{#927788}
This CL allows OfferNotificationBubbleViews to take in a promo code offer and display its details along with a copyable merchant promo code. Still to be done in followup CLs: 1) The G icon will be a followup, as it requires changing a shared class and thus several additional files 2) The offer omnibox icon needs to be flipped horizontally per a new request from UX 3) Metrics for clicking the promo code copy button Mock screenshot: https://screenshot.googleplex.com/e45dmfFSyNb7vKT.png Impl screenshot: https://screenshot.googleplex.com/3dC2gAR3R7YmyVP.png (Dark mode mock/impl screenshots forthcoming) Bug: 1248523 Change-Id: I62a90b1f1354f0ffe00a675cadd82e8249a9cc67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183625 Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Siyu An <siyua@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/main@{#927789}
Also added the respective delegate method "didTapLearnMoreButton" Bug: 1252794 Change-Id: Ia04b0ed471744ebcb1eb0b604c3a7374e1e78a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199490 Reviewed-by: Javier Flores <javierrobles@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Ginny Huang <ginnyhuang@chromium.org> Cr-Commit-Position: refs/heads/main@{#927790}
This CL updates MenuControllerCocoa and related classes to take a ColorProvider instance which is used to paint the NewTagImage and IPHDotImage for Cocoa context menus. This replaces the use of the global NativeTheme instance that is in the process of being deprecated by the Views team. The ColorProvider instance is taken from the Widget of the context menu's source hierarchy where possible. Currently this is only needed for render view context menus and Menus created in Views via a MenuRunner. Note: Code should not hold references to a give ColorProvider instance as they may be destroyed at arbitrary times. -[MenuControllerCocoa initWithModel:] has been updated to set the instance variables but not initialize the menu itself until -menu: is called. This allows creation of the context menu to be deferred to when the ColorProvider instance from the calling context is known. This has been done since previously initWithModel would be called in MenuRunnerImpl's constructor but the ColorProvider is often not known during construction (but is instead known when RunMenuAt() is called later on). Bug: 1056756 Change-Id: I2a6caed5c0b4daf32c5e53f41ea7740719d88344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3164141 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/main@{#927791}
This CL:
- Breaks all popup selection logic dependencies on OmniboxEditModel
- Moves selection logic from OmniboxEditModel to OmniboxPopupSelection
- Renames omnibox_popup_model.{h,cc} to omnibox_popup_selection.{h,cc}
- Updates all usages of the headers, eliminating several as unnecessary
- Combines the two `TestOmniboxEditModel` classes into one
- Moves popup-related tests of OmniboxEditModel into its unittest.cc
- Simplifies the code in several places to improve readability
Bug: 1208026
Change-Id: I059737a938c5deeae5d379ff1b4ae0b6976c89d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198798
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#927792}
Bug: 1252935 Change-Id: Ie5d1e6ac71629db150089549021d64984addfe41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199192 Reviewed-by: Gordon Seto <gordonseto@google.com> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/main@{#927793}
This CL adds a feature allowing to switch the strings of the new FRE Sync screen between the "new" strings and the strings currently in the old Sync screen. Bug: 1255147 Change-Id: I8ebb8c4604c1c00e1007949992e1fc41191aa062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199919 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Jérôme <jlebel@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/main@{#927794}
It's not used (anymore). Fixed: 1187037 Change-Id: I02bd036020277949f61bfb9923ced2ac2b9d9d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201974 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#927795}
See go/photos-exp-chrome-ntp and Metrics section of go/ntp-memories-eng-design for more details. Bug: 1230867 Change-Id: I550ea79b1f7db3e1af8b09717157471246136a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195175 Commit-Queue: Jeremy Selier <jerem@google.com> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/main@{#927796}
This reverts commit a0d0889. Reason for revert: BluetoothDeviceListItemViewTest.HasCorrectIcon fails under debug configuration. https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/25752/overview Original change's description: > [CrOS Bluetooth] Implement BluetoothDeviceListItemView. > > This change implements the class responsible for managing the view for a > specific device within the device list of the Bluetooth detailed view > within the Quick Settings. > > Examples of devices: > - https://screenshot.googleplex.com/AMi4rsiJ59Dus5D.png > - https://screenshot.googleplex.com/Ae5S7qigGf7KBA6.png > > Bug: 1010321 > Change-Id: I938e70cb4d5ab184accff82f438831bc3dba3484 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3171493 > Commit-Queue: Chad Duffin <chadduffin@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Gordon Seto <gordonseto@google.com> > Cr-Commit-Position: refs/heads/main@{#927728} Bug: 1010321 Change-Id: I826dbfe9287a7f08dcb748114ceac02771575af2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202537 Reviewed-by: Gordon Seto <gordonseto@google.com> Reviewed-by: Roman Arora <romanarora@google.com> Owners-Override: Roman Arora <romanarora@google.com> Commit-Queue: Roman Arora <romanarora@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Chad Duffin <chadduffin@chromium.org> Cr-Commit-Position: refs/heads/main@{#927797}
Bug: 1060690 Test: --gtest_filter=ShortcutCustomizationAppBrowserTest.\ MANUAL_FakeShortcut* Change-Id: I8543fc445c41547b0329c3c4cd825f4cb560f8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177682 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/main@{#927798}
This CL continues the expansion of the unit test suite for accessibility on Android by adding more performAction tests. With this CL we add tests for clearing and focusing a node, and giving a node accessibility focus or clearing accessibility focus. We add some clarifying comments to existing tests, and remove a dead method. We also fix a rare edge case with the SET_PROGRESS action that would prevent a user explicitly setting the progress of a slider to -1. We fix an undiscovered caching issue when a new node is focused in Android by clearing the AccessibilityNodeInfo cache for both the previously focused node and the newly focused node, whereas to date we have mistakenly only been clearing the newly focused node, which could be producing rare and hard to reproduce bugs. AX-Relnotes: N/A Bug: N/A Change-Id: Ib7ea938f87a588cab7406a70e023f55b18790078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199701 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/main@{#927799}
When the swap chain is recreated, it re-adds the Delegated Ink visual to the Visual Tree, but, if the clipping rect was committed in a previous step, this will not commit it again. The same happens to the ink color. This happens on Edge when edge-pc-ui-integration is enabled. In this scenario, there's a transparency on the window when it is focused, and not when it isn't. The swap chain is recreated when switching transparency modes. (e.g. Alt+Tab). When that happens, one sees the DelegatedInk painted with an offset from the cursor in black (instead of expected color). This CL fixes it by adding by setting a flag when the Swap Chain is recreated, that is latter used when setting up the DelegatedInk and the ink visual. Bug: 1253632, 1253674, 1052145 Change-Id: I38c9035389d73f54c5552ebdbe77b1c10e52978f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3188731 Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: João Victor Almeida de Aguiar <joalmei@microsoft.com> Cr-Commit-Position: refs/heads/main@{#927800}
The bundletool jar path containing version is listed in a few places in the build system. Remove the version from the jar path (autoroller cannot update all these places with the new version number). Also adds the bundletool jar path as a input to a few actions to avoid stale builds from cls just updating bundletool. Change-Id: I8d497bb882008ad4e34a5a0aa795ee4df5625e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200346 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#927801}
WCO = Window Controls Overlay CCT = Custom Tab Bar (previously Chrome Custom Tab) Problem: When a WCO app navigates out of the scope defined in the app manifest, the CCT appears and the app falls back to a "standalone" title bar so that the overlay doesn't overlap the CCT. When the app is in this state, there is plenty of room in the full size title bar for a user to drag the app, so draggable regions are not necessary. This change uses BrowserView's IsWindowControlsOverlayEnabled when determining if draggable regions should be used since it checks both: 1) if the preferred mode is to have WCO enabled 2) if the CCT or InfoBar are visible (in which case WCO is disabled) whereas the app_controller's IsWindowControlsOverlayEnabled only checks the first scenario. Note: the current code is a bit confusing, so we have a bug tracking work to refactor this: crbug.com/1254886 Bug: 1254512 Change-Id: If06071ebd1ca2c76fe8e90c977d6ac3b263659d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198894 Reviewed-by: Caroline Rising <corising@chromium.org> Commit-Queue: Amanda Baker <ambake@microsoft.com> Cr-Commit-Position: refs/heads/main@{#927802}
Previously, iframes only knew about ScreenInfo singular. This change adjusts all of the plumbing through frame visual properties to handle ScreenInfos plural. This extends the WindowPlacementBrowserTest to handle local and remote iframes, which go through different codepaths. Bug: 1182855 Change-Id: I74aa35597a5e936bf304c1ed01c1444902b1bf90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3154757 Commit-Queue: enne <enne@chromium.org> Reviewed-by: Mike Wasserman <msw@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/main@{#927803}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )