From f09001380c73446f7e89300fd6a9eecd63692445 Mon Sep 17 00:00:00 2001
From: Esko Luontola <esko.luontola@gmail.com>
Date: Sun, 27 Jul 2014 22:12:19 +0300
Subject: [PATCH] TODO notes

---
 TODO.txt                                           | 14 +++++++-------
 .../jumi/core/ipc/CommandsDirectoryObserver.java   |  1 +
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/TODO.txt b/TODO.txt
index 66139db8..d3dbda7c 100644
--- a/TODO.txt
+++ b/TODO.txt
@@ -187,13 +187,13 @@ OK - refactor BuildTest & SuiteConfiguration
 				OK - read commands from every new command file (daemon-dir/commands/*/request)
 				OK - read commands until IPC channel closed (though typically only one command per file)
 				OK - something to manage the daemon dir, e.g. creating command dirs
-				!! - write result to a corresponding file (daemon-dir/commands/*/reply)
-					- include the suite results file path in the reply (daemon-dir/suites/*/suite)
-					- write suite results to a MMF
-					- write suite results header before sending the reply
-				- close and forget the command MMFs after use
-				- close the suite results MMF after the suite is finished
-				- start it in Main, alongside DaemonNetworkEndpoint (using a different SuiteFactory instance?)
+				OK - write result to a corresponding file (daemon-dir/commands/*/reply)
+					OK - include the suite results file path in the reply (daemon-dir/suites/*/suite)
+					OK - write suite results to a MMF
+					OK - write suite results header before sending the reply
+				OK - close and forget the command MMFs after use
+				OK - close the suite results MMF after the suite is finished
+				!! - start it in Main, alongside DaemonNetworkEndpoint (using a different SuiteFactory instance?)
 		- switch to communicating over MMFs
 			- rename ProcessStartingDaemonSummoner to NetworkedProcessStartingDaemonSummoner
 			- rename RemoteSuiteLauncher to NetworkedRemoteSuiteLauncher
diff --git a/jumi-core/src/main/java/fi/jumi/core/ipc/CommandsDirectoryObserver.java b/jumi-core/src/main/java/fi/jumi/core/ipc/CommandsDirectoryObserver.java
index f9ba5c0d..96b94d2a 100644
--- a/jumi-core/src/main/java/fi/jumi/core/ipc/CommandsDirectoryObserver.java
+++ b/jumi-core/src/main/java/fi/jumi/core/ipc/CommandsDirectoryObserver.java
@@ -21,6 +21,7 @@ public CommandsDirectoryObserver(DaemonDir daemonDir, Executor executor, ActorTh
         directoryObserver = new DirectoryObserver(daemonDir.getCommandsDir(), new DirectoryObserver.Listener() {
             @Override
             public void onFileNoticed(Path path) {
+                // TODO: check that the path is really a directory?
                 executor.execute(new IpcCommandReceiver(daemonDir, new CommandDir(path), commandListener, actorThread));
             }
         });