You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The get_response function takes image_path but the variable is unused.
I assumed it would be useful if targeting another LMM like GPT4V; however, the code to set the image path as a user message is not there so I wanted to confirm.
What was the intention of the image_path variable in the models?
Thank you for pointing it out! The image_path variable was intentionally included to maintain consistency in the function signatures across different models.
The
get_response
function takesimage_path
but the variable is unused.I assumed it would be useful if targeting another LMM like GPT4V; however, the code to set the image path as a user message is not there so I wanted to confirm.
What was the intention of the image_path variable in the models?
I see the
image_path
is actually used forBard
,MathVista/models/bard.py
Lines 28 to 36 in 82f68d0
but not used for
Claude
orGPT
Is this an oversight and it should be used or was this intentional simply to keep the signature of functions the same?
MathVista/models/claude.py
Lines 17 to 39 in 82f68d0
MathVista/models/gpt.py
Lines 16 to 40 in 82f68d0
The text was updated successfully, but these errors were encountered: