New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return None when str coercion fails or when empty #20

Closed

mattmazzola wants to merge 1 commit into lupantech:main from mattmazzola:patch-2

Contributor

mattmazzola commented Feb 15, 2024

Returning None when extraction is empty prevents choosing one of the choices based on Levenshtein distance
Also return None on str coercion failure since returning empty string would return None later anyways, and it also seems like an incorrect extraction fallback value

Fixes #19


          Return None when str coercion fails or when empty

37d5706

Fixes lupantech#19

Owner

lupantech commented Sep 15, 2024

Hi @mattmazzola,

This pull requested has been resloved in #22.

Thank you very much for your invaluable contributions!!

lupantech closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet